Bug 819591 - Package Review: cvsps
Summary: Package Review: cvsps
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Honza Horak
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-07 16:14 UTC by Michal Luscon
Modified: 2012-05-10 12:20 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-05-10 12:20:30 UTC
Type: Bug
Embargoed:
hhorak: fedora-review+


Attachments (Terms of Use)

Description Michal Luscon 2012-05-07 16:14:41 UTC
Checked git commit:
048e66bf82d60a701cc2b622f4721779c3372cfb

YES source files match upstream - cvsps-2.2b1.tar.gz
YES package meets naming 
NO package meets versioning guidelines. Pre-version should be marked as b.1 instead of b1.
YES specfile is properly named, is cleanly written and uses macros consistently.
YES dist tag is present.
YES clean section and buildroot are present
YES license field matches the actual license
YES license is open source-compatible 
YES license text included in package
YES latest version is being packaged
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES package builds in mock
YES debuginfo package looks complete.
NO rpmlint is silent - incorrect-fsf-address /usr/share/doc/cvsps-2.2/COPYING
YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES scriptlets must be sane.
YES code, not content.
N/A large documentation files must go in a -doc subpackage.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.

Comment 1 Ville Skyttä 2012-05-08 07:49:39 UTC
(In reply to comment #0)

> NO package meets versioning guidelines. Pre-version should be marked as b.1
> instead of b1.

This is incorrect, b1 is fine here as it's preceded by 0.x.

Comment 2 Honza Horak 2012-05-09 10:29:45 UTC
(In reply to comment #0)
> NO rpmlint is silent - incorrect-fsf-address /usr/share/doc/cvsps-2.2/COPYING

I've reported this to upstream.

Comment 3 Honza Horak 2012-05-10 12:20:30 UTC
It seems all inconsistencies are addressed, so closing.


Note You need to log in before you can comment on or make changes to this bug.