Bug 820637
Summary: | Add grub2 theming | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Tom "spot" Callaway <tcallawa> |
Component: | fedora-logos | Assignee: | Tom "spot" Callaway <tcallawa> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 17 | CC: | awilliam, bruno, farrellj, mads, piotrdrag, pjones, robatino, tcallawa |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | AcceptedNTH | ||
Fixed In Version: | anaconda-17.27-1.fc17 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-05-18 23:02:52 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 752653 |
Description
Tom "spot" Callaway
2012-05-10 14:48:56 UTC
+1 NTH. I don't think adding a theme is likely to be a dangerous change. the apparent change to 'graphical mode', if anything, would be the dangerous change, but that seems to have already landed. so taking the theme on top isn't really likely to hurt anything, and makes it all look nicer. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers as always, though, I _do_ wish we could get these changes in earlier. there was plenty of opportunity to land changes to the bootloader earlier. Doesn't this also need a change to anaconda to write the GRUB_THEME line? -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers I believe that the answer here is no, because /etc/default/grub will have the proper setting. Peter would know for sure though. +1 nth, having a pretty bootloader is nice +1 NTH +1 NTH if it doesn't break the world spot: well, I tested a live image with the updated grub2 and fedora-logos, and it still wasn't themed after install. Accepted as NTH with the above votes. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Hmm. Peter, any ideas? +1 NTH as it affects installs and is unlikely to break things in a not clearly visible manner. This is fixed in anaconda-17.27-1 : * Mon May 14 2012 Brian C. Lane <bcl> - 17.27-1 - anaconda-cleanup: umount /run/media too (#820750) (bcl) - Disable md /boot and /boot/efi on EFI. (#816823) (dlehman) - dracut: use nfs3 by default (#811242) (wwoods) - script.py error message needs gettext (bcl) - We have a grub2 theme now, so say to use it. (pjones) Setting VERIFIED, as tflink mentioned on IRC last night he'd seen the new theme on an install from his test ISO. I'll confirm with TC6 also. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers 17.27 went stable. closing. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers |