Bug 821440
| Summary: | nss-softokn initialization memory leak | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Aleš Mareček <amarecek> |
| Component: | nss-softokn | Assignee: | Elio Maldonado Batiz <emaldona> |
| Status: | CLOSED DUPLICATE | QA Contact: | BaseOS QE Security Team <qe-baseos-security> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 6.3 | CC: | eparis, kdudka, kengert |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | nss-softokn-3.14.3-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-07 18:53:20 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Aleš Mareček
2012-05-14 13:42:25 UTC
This request was not resolved in time for the current release. Red Hat invites you to ask your support representative to propose this request, if still desired, for consideration in the next release of Red Hat Enterprise Linux. This request was erroneously removed from consideration in Red Hat Enterprise Linux 6.4, which is currently under development. This request will be evaluated for inclusion in Red Hat Enterprise Linux 6.4. This request was evaluated by Red Hat Product Management for inclusion in the current release of Red Hat Enterprise Linux. Because the affected component is not scheduled to be updated in the current release, Red Hat is unable to address this request at this time. Red Hat invites you to ask your support representative to propose this request, if appropriate, in the next release of Red Hat Enterprise Linux. Hi Kamil, I wonder if you have some time to look into this issue? We are wondering if the bug could potentially be in the curl module. Bob was wondering: "is curl calling NSS_Shutdown and not leaking any NSS references?" If you have time to check, that would be awesome :) Thanks in advance (In reply to comment #5) > We are wondering if the bug could potentially be in the curl module. No. > Bob was wondering: > "is curl calling NSS_Shutdown and not leaking any NSS references?" Yes. > If you have time to check, that would be awesome :) You need this fix from upstream: $ cvs diff -r 1.28 -r 1.29 lib/softoken/sftkdb.c Index: lib/softoken/sftkdb.c =================================================================== RCS file: /cvsroot/mozilla/security/nss/lib/softoken/sftkdb.c,v retrieving revision 1.28 retrieving revision 1.29 diff -r1.28 -r1.29 1497a1498,1500 > if (handle->passwordKey.data) { > PORT_ZFree(handle->passwordKey.data, handle->passwordKey.len); > } (In reply to comment #6) > (In reply to comment #5) > You need this fix from upstream: > > $ cvs diff -r 1.28 -r 1.29 lib/softoken/sftkdb.c > Index: lib/softoken/sftkdb.c > =================================================================== > RCS file: /cvsroot/mozilla/security/nss/lib/softoken/sftkdb.c,v > retrieving revision 1.28 > retrieving revision 1.29 > diff -r1.28 -r1.29 > 1497a1498,1500 > > if (handle->passwordKey.data) { > > PORT_ZFree(handle->passwordKey.data, handle->passwordKey.len); > > } Thank you Kamil. To add to this, the cvs log shows: $ cvs diff -up -r 1.28 -r 1.29 sftkdb.c Index: sftkdb.c =================================================================== RCS file: /cvsroot/mozilla/security/nss/lib/softoken/sftkdb.c,v retrieving revision 1.28 retrieving revision 1.29 diff -u -p -r1.28 -r1.29 --- sftkdb.c 13 Apr 2011 00:10:26 -0000 1.28 +++ sftkdb.c 1 Sep 2011 20:04:54 -0000 1.29 @@ -1495,6 +1495,9 @@ sftkdb_CloseDB(SFTKDBHandle *handle) } (*handle->db->sdb_Close)(handle->db); } + if (handle->passwordKey.data) { + PORT_ZFree(handle->passwordKey.data, handle->passwordKey.len); + } if (handle->passwordLock) { SKIP_AFTER_FORK(PZ_DestroyLock(handle->passwordLock)); } [emaldona@dhcp-32-223 softoken]$ cvs log sftkdb.c | less [emaldona@dhcp-32-223 softoken]$ cvs log sftkdb.c | grep "1.29" NSS_3_13_6_WITH_CKBI_1_93_RTM: 1.29 .... skipped ..... NSS_3_13_RTM: 1.29 NSS_3_13_RC0: 1.29 NSS_3_13_BETA2: 1.29 that it was fixed with the NSS_13_RTM upstream release. This bug was originally reported against nss-softokn-3.12.9 and the fix came on 3.13 to which we are were not at liberty to rebase the crypto module until now. Due to the Lucky 13 issue we are now free to rebase softoken to 3.14.3 for both rhel-6.5 and rhel-6.4.z so we are picking up the fix. Retesting with valgrind should confirm we have the fix. Marking it as fixed in nss-softokn-3.14.3-1.el6, not the latest build but the first were we rebased so I'm quoting that as the build. I am going to close this bug as a dup of 919172 919172 was a major rebase with a fix for this problem. *** This bug has been marked as a duplicate of bug 919172 *** |