Bug 821889
| Summary: | Review Request: sphinx-webtools - Sphinx web tools for python web frameworks | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrea Veri <andrea.veri> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-06-07 03:06:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Andrea Veri
2012-05-15 16:54:51 UTC
I'll review this. Look for a full review in a bit. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (BSD) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: (md5's don't match because of timestamp differences, contents are the same) 8241b4a44d3af52ab44c2c8f48fed441 sphinx-webtools-0.2.1.20120515.hg86a2eac02afe.tar.gz 150001f6bf73a0dca6c94092ab2be8be sphinx-webtools-0.2.1.20120515.hg86a2eac02afe.tar.gz.orig OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. There's a test suite, might run it in a %check section? python setup.py test 2. rpmlint says: sphinx-webtools.noarch: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist sphinx-webtools.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist sphinx-webtools.src: W: invalid-url Source0: sphinx-webtools-0.2.1.20120515.hg86a2eac02afe.tar.gz 2 packages and 0 specfiles checked; 0 errors, 3 warnings. All can be ignored. I don't see any blockers here, so this package is APPROVED. Please do consider enabling the tests if they work ok in mock. Tests enabled as per: http://averi.fedorapeople.org/RPMs/sphinx-webtools/sphinx-webtools-0.2.1-20120516.hg86a2eac02afe.fc16.src.rpm and http://averi.fedorapeople.org/RPMs/sphinx-webtools/sphinx-webtools.spec New Package SCM Request ======================= Package Name: sphinx-webtools Short Description: Sphinx web tools for python web frameworks Owners: averi Branches: f17 el5 el6 InitialCC: averi Git done (by process-git-requests). sphinx-webtools-0.2.1-20120516.hg86a2eac02afe.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/sphinx-webtools-0.2.1-20120516.hg86a2eac02afe.el6 sphinx-webtools-0.2.1-20120516.hg86a2eac02afe.el6 has been pushed to the Fedora EPEL 6 testing repository. sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.el6 sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc19 sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc18 sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc17 sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |