Spec URL: http://averi.fedorapeople.org/RPMs/sphinx-webtools/sphinx-webtools.spec
SRPM URL: http://averi.fedorapeople.org/RPMs/sphinx-webtools/sphinx-webtools-0.2.1-20120515.hg86a2eac02afe.fc16.src.rpm
Description: This package includes some tools to manage sphinx docs on the Python web framework: generate docs, get contents and links, search functionalities.
I'll review this. Look for a full review in a bit.
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
OK - License (BSD)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
(md5's don't match because of timestamp differences, contents are the same)
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Package obey's FHS standard (except for 2 exceptions)
See below - No rpmlint output.
OK - final provides and requires are sane.
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have sane scriptlets.
OK - Should have dist tag
OK - Should package latest version
OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin
1. There's a test suite, might run it in a %check section?
python setup.py test
2. rpmlint says:
sphinx-webtools.noarch: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
sphinx-webtools.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist
sphinx-webtools.src: W: invalid-url Source0: sphinx-webtools-0.2.1.20120515.hg86a2eac02afe.tar.gz
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
All can be ignored.
I don't see any blockers here, so this package is APPROVED.
Please do consider enabling the tests if they work ok in mock.
Tests enabled as per:
New Package SCM Request
Package Name: sphinx-webtools
Short Description: Sphinx web tools for python web frameworks
Branches: f17 el5 el6
Git done (by process-git-requests).
sphinx-webtools-0.2.1-20120516.hg86a2eac02afe.el6 has been submitted as an update for Fedora EPEL 6.
sphinx-webtools-0.2.1-20120516.hg86a2eac02afe.el6 has been pushed to the Fedora EPEL 6 testing repository.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.el6 has been submitted as an update for Fedora EPEL 6.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc19 has been submitted as an update for Fedora 19.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc18 has been submitted as an update for Fedora 18.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc17 has been submitted as an update for Fedora 17.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.
sphinx-webtools-0.2.1-20120528.hg86a2eac02afe.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.