Bug 823046

Updates per comments in bug 823043

- Removed BuildRoot
- Changed php require to php-common
- Added the following requires based on phpci results:
  php-ctype, php-dom, php-libxml, php-pcre, php-spl, php-simplexml
- Removed %defattr from %files section

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-DependencyInjection.spec

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-DependencyInjection-2.0.14-2.fc16.src.rpm

Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5

- Moved documentation to correct location

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-DependencyInjection.spec

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-DependencyInjection-2.0.14-3.fc16.src.rpm

Updated to upstream version 2.0.15 & updates per bug #817303

- Removed "BuildRequires: php-pear >= 1:1.4.9-1.2"
- Updated %prep section
- Removed cleaning buildroot from %install section
- Removed documentation move from %install section (fixed upstream)
- Removed %clean section
- Updated %doc in %files section

SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-DependencyInjection.spec

SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-DependencyInjection-2.0.15-1.fc16.src.rpm

Created attachment 589962 [details]
php-symfony2-DependencyInjection-review.txt

Generated by fedora-review 0.1.3

SHOULD: From package.xml, there are 2 optionnal deps.
php-pear(pear.symfony.com/Config)
php-pear(pear.symfony.com/Yaml)


It's a packager choice to make this (mandatory) Requires.

If you choose to add this requires, you can also remove
%dir %{pear_phpdir}/Symfony/Component
%dir %{pear_phpdir}/Symfony


No blocker.

=== APPROVED ===

New Package SCM Request
=======================
Package Name: php-symfony2-DependencyInjection
Short Description: Symfony2 DependencyInjection Component
Owners: siwinski
Branches: f16 f17 el6
InitialCC:

Git done (by process-git-requests).

So for late error detection

DependencyInjection/Loader/schema/dic/services/services-1.0.xsd should be installed as role="php", not as role="doc" as this path is referred in the code

In DependencyInjection/Loader/XmlFileLoader.php

   $schemaLocations = array('http://symfony.com/schema/dic/services' 
   => str_replace('\\', '/', __DIR__.'/schema/dic/services/services-1.0.xsd'));


Like for "Locale" this should be reported upstream, and role="data" is probably a better solution.

(In reply to comment #8)
> So for late error detection
> 
> DependencyInjection/Loader/schema/dic/services/services-1.0.xsd should be
> installed as role="php", not as role="doc" as this path is referred in the
> code
> 
> In DependencyInjection/Loader/XmlFileLoader.php
> 
>    $schemaLocations = array('http://symfony.com/schema/dic/services' 
>    => str_replace('\\', '/',
> __DIR__.'/schema/dic/services/services-1.0.xsd'));
> 
> 
> Like for "Locale" this should be reported upstream, and role="data" is
> probably a better solution.

Thanks for finding this Remi.  I will make sure to fix the issue before proceeding.

I will get upstream to fix the package.xml role for the *.xsd file.  It will take a code change to allow for role="data", but I will work with upstream to fix the issue.  If role="data" will take some time to implement, is it fine to revert to role="php" for now and plan on role="data" for a future enhancement?

I looked through all the other php-symfony2-* packages and it appears this same error exists in version 2.0.15 for the Routing, Translation, and Validator packages as well.  I will update those reviews with this information and work with upstream to fix.

Since these fixes upstream will require a new release (probably 2.0.16), may I just fix the package.xml in the spec file?

(In reply to comment #9)
> If role="data" will take some time to implement, is it
> fine to revert to role="php" for now and plan on role="data" for a future
> enhancement?

Yes.

> Since these fixes upstream will require a new release (probably 2.0.16), may
> I just fix the package.xml in the spec file?

Yes

Fixed issue from comment #8 and commited -- http://pkgs.fedoraproject.org/gitweb/?p=php-symfony2-DependencyInjection.git;a=commitdiff;h=0f9a2d6cd3705961302de1617e238e585fc04516

php-symfony2-DependencyInjection-2.0.15-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/php-symfony2-DependencyInjection-2.0.15-3.fc17

php-symfony2-DependencyInjection-2.0.15-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/php-symfony2-DependencyInjection-2.0.15-3.fc16

php-symfony2-DependencyInjection-2.0.15-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-symfony2-DependencyInjection-2.0.15-3.el6

php-symfony2-DependencyInjection-2.0.15-3.fc17 has been pushed to the Fedora 17 testing repository.

php-symfony2-DependencyInjection-2.0.15-3.fc16 has been pushed to the Fedora 16 stable repository.

php-symfony2-DependencyInjection-2.0.15-3.fc17 has been pushed to the Fedora 17 stable repository.

php-symfony2-DependencyInjection-2.0.15-3.el6 has been pushed to the Fedora EPEL 6 stable repository.