Red Hat Bugzilla – Bug 823073
Review Request: php-symfony2-HttpKernel - Symfony2 HttpKernel Component
Last modified: 2012-07-20 20:22:25 EDT
Spec URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpKernel.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpKernel-2.0.14-1.fc16.src.rpm Description: Symfony2 HttpKernel Component.
Updates per comments in bug 823043 - Removed BuildRoot - Changed php require to php-common - Added the following requires based on phpci results: php-ctype, php-date, php-pcre, php-spl, php-tokenizer - Removed %%defattr from %%files section - Removed ownership for directories already owned by required packages Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5 - Moved documentation to correct location SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpKernel.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpKernel-2.0.14-3.fc16.src.rpm
Updated to upstream version 2.0.15 & updates per bug #817303 - Removed "BuildRequires: php-pear >= 1:1.4.9-1.2" - Updated %prep section - Removed cleaning buildroot from %install section - Removed documentation move from %install section (fixed upstream) - Removed %clean section - Updated %doc in %files section SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpKernel.spec SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpKernel-2.0.15-1.fc16.src.rpm
Added optional requires - Added php-pear(%{pear_channel}/BrowserKit) require - Added php-pear(%{pear_channel}/ClassLoader) require - Added php-pear(%{pear_channel}/Config) require - Added php-pear(%{pear_channel}/Console) require - Added php-pear(%{pear_channel}/DependencyInjection) require - Added php-pear(%{pear_channel}/Finder) require SPEC URL: http://people.redhat.com/~siwinski/rpmbuild/SPECS/php-symfony2-HttpKernel.spec SRPM URL: http://people.redhat.com/~siwinski/rpmbuild/SRPMS/php-symfony2-HttpKernel-2.0.15-2.fc17.src.rpm
Created attachment 594231 [details] php-symfony2-HttpKernel-review.txt Generated by fedora-review 0.1.3
Optionnal dependencies detected. HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/MysqlProfilerStorage.php => pdo_mysql HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/PdoProfilerStorage.php => pdo HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/SqliteProfilerStorage.php => sqlite3 Probably php-pdo and php-sqlite3 (same package) could be added (no additionnal libraries required, as libsqlite always installed, for rpm) php-pdo_mysql should be considered
No blocker === APPROVED ===
(In reply to comment #5) > Optionnal dependencies detected. > HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/MysqlProfilerStorage. > php => pdo_mysql > HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/PdoProfilerStorage. > php => pdo > HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/ > SqliteProfilerStorage.php => sqlite3 > > Probably php-pdo and php-sqlite3 (same package) could be added (no > additionnal libraries required, as libsqlite always installed, for rpm) I'll add "php-pdo" and "php-sqlite3" requires after the approved package import. > php-pdo_mysql should be considered Looking through the requires for php-pdo_mysql (virtual package of php-mysql), it simply has a require of "php-pdo". Since "php-pdo" is already going to be required, I'll go ahead and require "php-pdo_mysql" as well so all optional dependencies will be accounted for. As always, thank Remi!
New Package SCM Request ======================= Package Name: php-symfony2-HttpKernel Short Description: Symfony2 HttpKernel Component Owners: siwinski Branches: f16 f17 el6 InitialCC:
Git done (by process-git-requests).
php-symfony2-HttpKernel-2.0.15-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-symfony2-HttpKernel-2.0.15-3.fc17
php-symfony2-HttpKernel-2.0.15-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-symfony2-HttpKernel-2.0.15-3.fc16
php-symfony2-HttpKernel-2.0.15-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-symfony2-HttpKernel-2.0.15-3.el6
php-symfony2-HttpKernel-2.0.15-3.el6 has been pushed to the Fedora EPEL 6 testing repository.
php-symfony2-HttpKernel-2.0.15-3.fc16 has been pushed to the Fedora 16 stable repository.
php-symfony2-HttpKernel-2.0.15-3.fc17 has been pushed to the Fedora 17 stable repository.
php-symfony2-HttpKernel-2.0.15-3.el6 has been pushed to the Fedora EPEL 6 stable repository.