Bug 823073

Summary: Review Request: php-symfony2-HttpKernel - Symfony2 HttpKernel Component
Product: [Fedora] Fedora Reporter: Shawn Iwinski <shawn>
Component: Package ReviewAssignee: Remi Collet <fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rawhideCC: fedora, notting, package-review
Target Milestone: ---Flags: fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-12 18:58:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On: 814994, 823041, 823042, 823043, 823046, 823050, 823051, 823054, 823070    
Bug Blocks: 823075    
Attachments:
Description Flags
php-symfony2-HttpKernel-review.txt none

Comment 1 Shawn Iwinski 2012-05-20 22:10:34 UTC
Updates per comments in bug 823043

- Removed BuildRoot
- Changed php require to php-common
- Added the following requires based on phpci results:
  php-ctype, php-date, php-pcre, php-spl, php-tokenizer
- Removed %%defattr from %%files section
- Removed ownership for directories already owned by required packages

Update per https://bugzilla.redhat.com/show_bug.cgi?id=823041#c5

- Moved documentation to correct location

SPEC URL:
http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpKernel.spec

SRPM URL:
http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpKernel-2.0.14-3.fc16.src.rpm

Comment 2 Shawn Iwinski 2012-05-31 17:28:24 UTC
Updated to upstream version 2.0.15 & updates per bug #817303

- Removed "BuildRequires: php-pear >= 1:1.4.9-1.2"
- Updated %prep section
- Removed cleaning buildroot from %install section
- Removed documentation move from %install section (fixed upstream)
- Removed %clean section
- Updated %doc in %files section

SPEC URL: http://people.redhat.com/siwinski/rpmbuild/SPECS/php-symfony2-HttpKernel.spec

SRPM URL: http://people.redhat.com/siwinski/rpmbuild/SRPMS/php-symfony2-HttpKernel-2.0.15-1.fc16.src.rpm

Comment 3 Shawn Iwinski 2012-06-13 06:23:24 UTC
Added optional requires

- Added php-pear(%{pear_channel}/BrowserKit) require
- Added php-pear(%{pear_channel}/ClassLoader) require
- Added php-pear(%{pear_channel}/Config) require
- Added php-pear(%{pear_channel}/Console) require
- Added php-pear(%{pear_channel}/DependencyInjection) require
- Added php-pear(%{pear_channel}/Finder) require

SPEC URL: http://people.redhat.com/~siwinski/rpmbuild/SPECS/php-symfony2-HttpKernel.spec

SRPM URL: http://people.redhat.com/~siwinski/rpmbuild/SRPMS/php-symfony2-HttpKernel-2.0.15-2.fc17.src.rpm

Comment 4 Remi Collet 2012-06-25 16:11:39 UTC
Created attachment 594231 [details]
php-symfony2-HttpKernel-review.txt

Generated by fedora-review 0.1.3

Comment 5 Remi Collet 2012-06-25 16:14:42 UTC
Optionnal dependencies detected.
HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/MysqlProfilerStorage.php => pdo_mysql
HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/PdoProfilerStorage.php => pdo
HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/SqliteProfilerStorage.php => sqlite3

Probably php-pdo and php-sqlite3 (same package) could be added (no additionnal libraries required, as libsqlite always installed, for rpm)

php-pdo_mysql should be considered

Comment 6 Remi Collet 2012-06-25 16:15:08 UTC
No blocker

=== APPROVED ===

Comment 7 Shawn Iwinski 2012-06-25 17:11:54 UTC
(In reply to comment #5)
> Optionnal dependencies detected.
> HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/MysqlProfilerStorage.
> php => pdo_mysql
> HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/PdoProfilerStorage.
> php => pdo
> HttpKernel-2.0.15/Symfony/Component/HttpKernel/Profiler/
> SqliteProfilerStorage.php => sqlite3
> 
> Probably php-pdo and php-sqlite3 (same package) could be added (no
> additionnal libraries required, as libsqlite always installed, for rpm)

I'll add "php-pdo" and "php-sqlite3" requires after the approved package import.

> php-pdo_mysql should be considered

Looking through the requires for php-pdo_mysql (virtual package of php-mysql), it simply has a require of "php-pdo".  Since "php-pdo" is already going to be required, I'll go ahead and require "php-pdo_mysql" as well so all optional dependencies will be accounted for.

As always, thank Remi!

Comment 8 Shawn Iwinski 2012-06-25 17:14:46 UTC
New Package SCM Request
=======================
Package Name: php-symfony2-HttpKernel
Short Description: Symfony2 HttpKernel Component
Owners: siwinski
Branches: f16 f17 el6
InitialCC:

Comment 9 Gwyn Ciesla 2012-06-26 14:43:28 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2012-06-28 05:34:01 UTC
php-symfony2-HttpKernel-2.0.15-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/php-symfony2-HttpKernel-2.0.15-3.fc17

Comment 11 Fedora Update System 2012-06-28 05:34:34 UTC
php-symfony2-HttpKernel-2.0.15-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/php-symfony2-HttpKernel-2.0.15-3.fc16

Comment 12 Fedora Update System 2012-06-28 05:34:42 UTC
php-symfony2-HttpKernel-2.0.15-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/php-symfony2-HttpKernel-2.0.15-3.el6

Comment 13 Fedora Update System 2012-06-28 16:06:41 UTC
php-symfony2-HttpKernel-2.0.15-3.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 14 Fedora Update System 2012-07-12 18:58:02 UTC
php-symfony2-HttpKernel-2.0.15-3.fc16 has been pushed to the Fedora 16 stable repository.

Comment 15 Fedora Update System 2012-07-12 18:59:25 UTC
php-symfony2-HttpKernel-2.0.15-3.fc17 has been pushed to the Fedora 17 stable repository.

Comment 16 Fedora Update System 2012-07-21 00:22:25 UTC
php-symfony2-HttpKernel-2.0.15-3.el6 has been pushed to the Fedora EPEL 6 stable repository.