Bug 823641
| Summary: | Review Request: mingw-usbredir - MinGW USB network redirection protocol libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marc-Andre Lureau <marcandre.lureau> |
| Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | erik-fedora, hdegoede, notting, package-review |
| Target Milestone: | --- | Flags: | hdegoede:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-11-18 17:18:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marc-Andre Lureau
2012-05-21 18:50:34 UTC
Full review done: Good: -------- - rpmlint checks return: mingw32-usbredir-debuginfo.noarch: E: debuginfo-without-sources mingw32-usbredir-static.noarch: W: no-documentation mingw64-usbredir-debuginfo.noarch: E: debuginfo-without-sources mingw64-usbredir-static.noarch: W: no-documentation 7 packages and 0 specfiles checked; 2 errors, 2 warnings. ^^These are all expected for mingw packages, so no problem here ^^ - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales properly handled - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Should fix: --------------- - There is a "rm -rf $RPM_BUILD_ROOT" in your %install, this is not needed with modern rpm versions, and should not be there unless you also manually specify a buildroot and have a manual %clean section - BuildRequires: mingw*-libusb1 likely needs to become BuildRequires: mingw*-libusbx see the mingw-libusb1 review. Please fix both of these before building for the first time. No blockers -> Approved! (In reply to comment #1) > Should fix: > --------------- > - There is a "rm -rf $RPM_BUILD_ROOT" in your %install, this is not needed > with modern rpm versions, and > should not be there unless you also manually specify a buildroot and have > a manual %clean section > - BuildRequires: mingw*-libusb1 likely needs to become BuildRequires: > mingw*-libusbx see the > mingw-libusb1 review. > > Please fix both of these before building for the first time. fixed New Package SCM Request ======================= Package Name: mingw-usbredir Short Description: MinGW USB network redirection protocol libraries Owners: elmarco epienbro jwrdegoede Branches: f17 InitialCC: Git done (by process-git-requests). According to koji the initial build for Fedora 17 failed: http://koji.fedoraproject.org/koji/packageinfo?packageID=14281 Marc-Andre, could you investigate this and close this review ticket once the package has been built successfully for all branches? Marc-Andre, the mingw-usbredir package still isn't imported in the master branch and the Fedora 17 build failed. Could you please fix this and close this review ticket once you're done? mingw-usbredir-0.5.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-usbredir-0.5.2-1.fc18 (In reply to comment #6) > Marc-Andre, the mingw-usbredir package still isn't imported in the master > branch and the Fedora 17 build failed. Could you please fix this and close > this review ticket once you're done? Submitted: https://admin.fedoraproject.org/updates/mingw-usbredir-0.5.2-1.fc18 mingw-usbredir-0.5.2-1.fc18 has been pushed to the Fedora 18 stable repository. |