Spec URL: http://elmarco.fedorapeople.org/mingw-usbredir.spec SRPM URL: http://elmarco.fedorapeople.org/mingw-usbredir-0.4.3-1.fc17.src.rpm Description: The usbredir libraries allow USB devices to be used on remote and/or virtual hosts over TCP. Fedora Account System Username: elmarco
Full review done: Good: -------- - rpmlint checks return: mingw32-usbredir-debuginfo.noarch: E: debuginfo-without-sources mingw32-usbredir-static.noarch: W: no-documentation mingw64-usbredir-debuginfo.noarch: E: debuginfo-without-sources mingw64-usbredir-static.noarch: W: no-documentation 7 packages and 0 specfiles checked; 2 errors, 2 warnings. ^^These are all expected for mingw packages, so no problem here ^^ - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - locales properly handled - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Should fix: --------------- - There is a "rm -rf $RPM_BUILD_ROOT" in your %install, this is not needed with modern rpm versions, and should not be there unless you also manually specify a buildroot and have a manual %clean section - BuildRequires: mingw*-libusb1 likely needs to become BuildRequires: mingw*-libusbx see the mingw-libusb1 review. Please fix both of these before building for the first time. No blockers -> Approved!
(In reply to comment #1) > Should fix: > --------------- > - There is a "rm -rf $RPM_BUILD_ROOT" in your %install, this is not needed > with modern rpm versions, and > should not be there unless you also manually specify a buildroot and have > a manual %clean section > - BuildRequires: mingw*-libusb1 likely needs to become BuildRequires: > mingw*-libusbx see the > mingw-libusb1 review. > > Please fix both of these before building for the first time. fixed
New Package SCM Request ======================= Package Name: mingw-usbredir Short Description: MinGW USB network redirection protocol libraries Owners: elmarco epienbro jwrdegoede Branches: f17 InitialCC:
Git done (by process-git-requests).
According to koji the initial build for Fedora 17 failed: http://koji.fedoraproject.org/koji/packageinfo?packageID=14281 Marc-Andre, could you investigate this and close this review ticket once the package has been built successfully for all branches?
Marc-Andre, the mingw-usbredir package still isn't imported in the master branch and the Fedora 17 build failed. Could you please fix this and close this review ticket once you're done?
mingw-usbredir-0.5.2-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mingw-usbredir-0.5.2-1.fc18
(In reply to comment #6) > Marc-Andre, the mingw-usbredir package still isn't imported in the master > branch and the Fedora 17 build failed. Could you please fix this and close > this review ticket once you're done? Submitted: https://admin.fedoraproject.org/updates/mingw-usbredir-0.5.2-1.fc18
mingw-usbredir-0.5.2-1.fc18 has been pushed to the Fedora 18 stable repository.