Bug 823691

Summary: Agent tests use hard-coded port numbers
Product: [Other] RHQ Project Reporter: Ian Springer <ian.springer>
Component: TestsAssignee: John Sanda <jsanda>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 4.4CC: ccrouch, hrupp, jsanda
Target Milestone: ---   
Target Release: RHQ 4.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-01 10:18:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ian Springer 2012-05-21 21:59:03 UTC
This can cause intermittent test failures due to port conflicts, particularly when two jobs in Jenkins (e.g. rhq-master and rhq-release) run simultaneously on the same slave.

I think we need to either make the ports configurable via sysprops as we did for the comm tests, or add some code that finds a free port in a certain port range and then uses that port. I see the following hard-coded ports in the Agent*Test classes: 11111, 22222, 17777, 18888, 12345, 22345.

Comment 1 John Sanda 2012-06-11 18:43:17 UTC
Taking this bug since I had started doing some work on it already.

Comment 2 John Sanda 2012-06-12 19:47:55 UTC
The ports cited in the description have been parameterized. Changes have been pushed to master.

commit hash: fee4a644165

Comment 4 Heiko W. Rupp 2013-09-01 10:18:45 UTC
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.