Bug 823691 - Agent tests use hard-coded port numbers
Summary: Agent tests use hard-coded port numbers
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Tests
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: RHQ 4.5.0
Assignee: John Sanda
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-21 21:59 UTC by Ian Springer
Modified: 2013-09-01 10:18 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-09-01 10:18:45 UTC
Embargoed:


Attachments (Terms of Use)

Description Ian Springer 2012-05-21 21:59:03 UTC
This can cause intermittent test failures due to port conflicts, particularly when two jobs in Jenkins (e.g. rhq-master and rhq-release) run simultaneously on the same slave.

I think we need to either make the ports configurable via sysprops as we did for the comm tests, or add some code that finds a free port in a certain port range and then uses that port. I see the following hard-coded ports in the Agent*Test classes: 11111, 22222, 17777, 18888, 12345, 22345.

Comment 1 John Sanda 2012-06-11 18:43:17 UTC
Taking this bug since I had started doing some work on it already.

Comment 2 John Sanda 2012-06-12 19:47:55 UTC
The ports cited in the description have been parameterized. Changes have been pushed to master.

commit hash: fee4a644165

Comment 4 Heiko W. Rupp 2013-09-01 10:18:45 UTC
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.


Note You need to log in before you can comment on or make changes to this bug.