Bug 823737

Summary: rhevm gui upgrades should convert ethX devices to biosdevnames during update
Product: Red Hat Enterprise Linux 6 Reporter: Joey Boggs <jboggs>
Component: vdsmAssignee: Douglas Schilling Landgraf <dougsland>
Status: CLOSED DUPLICATE QA Contact: Haim <hateya>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 6.3CC: abaron, bazulay, danken, iheim, mburns, ovirt-maint, yeylon, ykaul
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-05-22 22:11:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 2 Dan Kenigsberg 2012-05-22 06:59:30 UTC
May I get a pointer to convert_to_biosdevname()? ovirt-node's git-grep gives me nothing.

If the suggested patch is sufficient, I think we can make it to 6.3's 0day.

Comment 5 Douglas Schilling Landgraf 2012-05-22 22:05:01 UTC
Talked with jboggs and mburns the ovirt-node guys will implement the upgrade as a service (ovirt-early), no changes are required in vdsm at this moment.

Comment 6 Douglas Schilling Landgraf 2012-05-22 22:11:02 UTC

*** This bug has been marked as a duplicate of bug 822848 ***

Comment 7 Dan Kenigsberg 2012-05-24 07:54:17 UTC
Folks, wouldn't we (and the rest of the world) have the same problem on a `yum upgrade` of a plain RHEL-6.2 to RHEL-6.3?

Comment 8 Mike Burns 2012-05-24 12:08:33 UTC
(In reply to comment #7)
> Folks, wouldn't we (and the rest of the world) have the same problem on a
> `yum upgrade` of a plain RHEL-6.2 to RHEL-6.3?

Only if you install biosdevnames as well, which shouldn't happen automatically.

Comment 9 Dan Kenigsberg 2012-05-29 22:29:34 UTC
I think we have another serious upgrade issue due to this. bug 822953 reminded me that Vdsm (foolishly! doh!) generates the host uuid based on the mac address of alphabetically-first host nic. With biosdevnames installed, nic names and order may change, leading to the node changing its uuid after upgrade. Maybe that's even a cause for bug 822925.

As a solution, we could hack the upgrade script to persist the pre-upgrade uuid on disk, and hack vdsm-reg to report the persisted copy.

Or we could ditch biosdevnames.

Comment 10 Dan Kenigsberg 2012-05-29 22:40:31 UTC
Sorry for being hysterical. Host macs are sorted by their address, not by their nic name (pun unintended). So installing biosdevnames is not expected to change the node id.