Bug 824019

Summary:	[as7] check that server's basedir has not changed since discovery needs to be added to server components' start() method
Product:	[Other] RHQ Project	Reporter:	Ian Springer <ian.springer>
Component:	Plugins	Assignee:	Charles Crouch <ccrouch>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Mike Foley <mfoley>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	4.4	CC:	ccrouch, hbrock, hrupp, jsanda
Target Milestone:	---
Target Release:	JON 3.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	823558	Environment:
Last Closed:	2013-09-04 09:01:43 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	823558
Bug Blocks:	707223

Description Ian Springer 2012-05-22 15:08:50 UTC

+++ This bug was initially created as a clone of Bug #823558 +++

This check is important, because the basedir is the resource key, and so if that changes, it's no longer the same server Resource, and start() should throw a InvalidPluginConfigurationException, which will result in a yellow triangle in the GUI.

We have such a check in the as4 and as5 plugins.

We should also move the launch-type and product-name checks that are currently in getAvailablity() to start().

Comment 1 Charles Crouch 2012-05-22 16:43:24 UTC

I'd like to get this in since it helps prevent user confusion when starting up different servers on the same port. Assuming this has good automated test coverage we should push this to the release/jon3.1.x branch

Comment 2 Ian Springer 2012-05-22 22:43:42 UTC

The fixes have been cherry-picked from master to the release/jon3.1.x branch:

http://git.fedorahosted.org/git?p=rhq/rhq.git;a=commitdiff;h=9559747
http://git.fedorahosted.org/git?p=rhq/rhq.git;a=commitdiff;h=2bc78a7
http://git.fedorahosted.org/git?p=rhq/rhq.git;a=commitdiff;h=1a11892
http://git.fedorahosted.org/git?p=rhq/rhq.git;a=commitdiff;h=db2731c

Comment 5 Heiko W. Rupp 2013-09-04 09:01:43 UTC

Closing for the old release as Bug 823558 has been fixed/implemented and the fixes were cp'd over.