Bug 824361
| Summary: | Review Request: whisper - Fixed size round-robin style database for graphite | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Aditya Patawari <adimania> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 17 | CC: | adimania, christof, gianluca.varisco, mrunge, notting, package-review, panemade, volker27 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | Stalled review | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-03 06:35:10 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Aditya Patawari
2012-05-23 10:47:02 UTC
Following the naming guidelines, the package should be called python-whisper: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29 Looking at https://launchpad.net/graphite/0.9/0.9.10/+download/check-dependencies.py, the minimum Python version seems to be 2.4 -- not 2.6. In case I'm wrong, this package can not go to EPEL 5, since EL 5 has 2.4. Therefore please delete the clean section and the cleaning rm in the install section. Also drop it, if you don't aim for EPEL 5 in general. The general defattr is not necessary. Please use the version macro in Source ("0.9.9"). BR python2-devel: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires I think you could add a bit more information to the description. ("%setup -q" would have been enough, but with the new name you'll have to use -n anyway. Also, use the name macro consistently.) There's a _sharedstatedir macro that resolves to "/var/lib". Please use that instead of _localstatedir and the lib string. I found an import of "rrdtool". You should therefore require rrdtool-python, I guess. You're also assuming a user called "graphite" to be present. This user seems to be created in your carbon package. You must therefore require it. Still interested? I'll wait another week. If you don't respond by then, I'll close this ticket, as of https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews Aditya, please have a look at https://bugzilla.redhat.com/show_bug.cgi?id=849381 Closed as announced |