Red Hat Bugzilla – Bug 824361
Review Request: whisper - Fixed size round-robin style database for graphite
Last modified: 2012-09-03 02:35:10 EDT
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4096064
Whisper is a round-robin style database for graphite. It features a sub-set of rrd. It is implemented in Python.
Following the naming guidelines, the package should be called python-whisper: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29
Looking at https://launchpad.net/graphite/0.9/0.9.10/+download/check-dependencies.py, the minimum Python version seems to be 2.4 -- not 2.6. In case I'm wrong, this package can not go to EPEL 5, since EL 5 has 2.4. Therefore please delete the clean section and the cleaning rm in the install section. Also drop it, if you don't aim for EPEL 5 in general.
The general defattr is not necessary.
Please use the version macro in Source ("0.9.9").
BR python2-devel: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
I think you could add a bit more information to the description.
("%setup -q" would have been enough, but with the new name you'll have to use -n anyway. Also, use the name macro consistently.)
There's a _sharedstatedir macro that resolves to "/var/lib". Please use that instead of _localstatedir and the lib string.
I found an import of "rrdtool". You should therefore require rrdtool-python, I guess. You're also assuming a user called "graphite" to be present. This user seems to be created in your carbon package. You must therefore require it.
I'll wait another week. If you don't respond by then, I'll close this ticket, as of https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
Aditya, please have a look at https://bugzilla.redhat.com/show_bug.cgi?id=849381
Closed as announced