Bug 824361 - Review Request: whisper - Fixed size round-robin style database for graphite
Review Request: whisper - Fixed size round-robin style database for graphite
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
Unspecified Unspecified
unspecified Severity unspecified
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
Stalled review
Depends On:
  Show dependency treegraph
Reported: 2012-05-23 06:47 EDT by Aditya Patawari
Modified: 2012-09-03 02:35 EDT (History)
8 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-09-03 02:35:10 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Aditya Patawari 2012-05-23 06:47:02 EDT
SPEC: http://adimania.fedorapeople.org/graphite/whisper.spec
SRPM: http://adimania.fedorapeople.org/graphite/whisper-0.9.9-1.fc17.src.rpm
Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4096064

Whisper is a round-robin style database for graphite. It features a sub-set of rrd. It is implemented in Python.
Comment 1 Volker Fröhlich 2012-05-27 16:31:41 EDT
Following the naming guidelines, the package should be called python-whisper: http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Addon_Packages_.28python_modules.29

Looking at https://launchpad.net/graphite/0.9/0.9.10/+download/check-dependencies.py, the minimum Python version seems to be 2.4 -- not 2.6. In case I'm wrong, this package can not go to EPEL 5, since EL 5 has 2.4. Therefore please delete the clean section and the cleaning rm in the install section. Also drop it, if you don't aim for EPEL 5 in general.

The general defattr is not necessary.

Please use the version macro in Source ("0.9.9").

BR python2-devel: http://fedoraproject.org/wiki/Packaging:Python#BuildRequires

I think you could add a bit more information to the description.

("%setup -q" would have been enough, but with the new name you'll have to use -n anyway. Also, use the name macro consistently.)

There's a _sharedstatedir macro that resolves to "/var/lib". Please use that instead of _localstatedir and the lib string.

I found an import of "rrdtool". You should therefore require rrdtool-python, I guess. You're also assuming a user called "graphite" to be present. This user seems to be created in your carbon package. You must therefore require it.
Comment 2 Volker Fröhlich 2012-07-22 16:07:23 EDT
Still interested?
Comment 3 Volker Fröhlich 2012-08-10 16:16:26 EDT
I'll wait another week. If you don't respond by then, I'll close this ticket, as of https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
Comment 4 Gianluca Varisco 2012-08-29 05:25:18 EDT
Aditya, please have a look at https://bugzilla.redhat.com/show_bug.cgi?id=849381
Comment 5 Volker Fröhlich 2012-09-03 02:35:10 EDT
Closed as announced

Note You need to log in before you can comment on or make changes to this bug.