Bug 825041

Summary: grub2 fails on F17 install when multiple distros present (os-prober)
Product: [Fedora] Fedora Reporter: IBM Bug Proxy <bugproxy>
Component: os-proberAssignee: Hedayat Vatankhah <hedayatv>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 17CC: hedayatv, jkachuck, wgomerin
Target Milestone: ---   
Target Release: ---   
Hardware: ppc64   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-02 23:56:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
original grub.cfg.new file created by current os-prober
none
40yaboot patch 1
none
40yaboot patch 2
none
anaconda program log none

Description IBM Bug Proxy 2012-05-24 22:00:38 UTC
Problem Description:

When you install F17, if you have multiple distros present other disks, the grub2-mkconfig will fail and leave you with an unbootable system.  It will create the grub.cfg.new file, but because it fails a syntax check, it will not rename it and allow grub to boot/configure properly.  Will attach relevant log files and such
 
As you can see, one of the key problems in that grub.cfg.new is in line 149.  It's apparent that the files in os-prober do not process the yaboot.conf file properly when the append is followed by a space and = sign.  Example:

append = "some params"
append="some params"

Both are acceptable to yaboot itself, but the /usr/libexec/linux-boot-probes/mounted/40yaboot script does not account for that.

We have attached two proposed patches for your consideration.

Comment 1 IBM Bug Proxy 2012-05-24 22:00:53 UTC
Created attachment 586717 [details]
original grub.cfg.new file created by current os-prober

Comment 2 IBM Bug Proxy 2012-05-24 22:01:07 UTC
Created attachment 586718 [details]
40yaboot patch 1

Comment 3 IBM Bug Proxy 2012-05-24 22:01:19 UTC
Created attachment 586719 [details]
40yaboot patch 2

Comment 4 IBM Bug Proxy 2012-05-24 22:01:32 UTC
Created attachment 586720 [details]
anaconda program log

Comment 5 Hedayat Vatankhah 2012-05-25 10:47:40 UTC
Thank you for reporting the problem and providing the patches. I think I'll go with the first patch, but I'll forward both to upstream.

Comment 6 Hedayat Vatankhah 2012-05-25 11:22:40 UTC
Hmm.. but I think there is no need to change case "$1" with case "${1%%=*}" since bash already do it (considering the IFS variable). Right?

Comment 7 Fedora Update System 2012-05-25 12:53:51 UTC
os-prober-1.53-2.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/os-prober-1.53-2.fc16

Comment 8 Fedora Update System 2012-05-25 12:54:07 UTC
os-prober-1.53-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/os-prober-1.53-2.fc17

Comment 9 IBM Bug Proxy 2012-05-25 13:00:59 UTC
------- Comment From baude.com 2012-05-25 12:55 EDT-------
I'll defer to you and others on that one. Please roll a new src rpm and let us know as this currently blocks ppc64 F17 RC.

Comment 10 Hedayat Vatankhah 2012-05-25 13:20:03 UTC
You can find the src.rpm at: http://koji.fedoraproject.org/koji/buildinfo?buildID=320525

Comment 11 IBM Bug Proxy 2012-05-25 14:01:40 UTC
------- Comment From baude.com 2012-05-25 13:54 EDT-------
I've tested the new package locally and it seems to fix the problem we are seeing.  The real test will be to get our IS rebuilt with the new package.

Comment 12 IBM Bug Proxy 2012-05-25 14:31:17 UTC
------- Comment From baude.com 2012-05-25 14:29 EDT-------
Is there any chance you could join us on freenode on #fedora-ppc?  I have some follow-up questions.

Comment 13 Fedora Update System 2012-05-26 08:07:10 UTC
Package os-prober-1.53-2.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing os-prober-1.53-2.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-8433/os-prober-1.53-2.fc17
then log in and leave karma (feedback).

Comment 14 Fedora Update System 2012-06-02 16:54:19 UTC
os-prober-1.53-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/os-prober-1.53-3.fc16

Comment 15 Fedora Update System 2012-06-02 16:55:45 UTC
os-prober-1.53-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/os-prober-1.53-3.fc17

Comment 16 Fedora Update System 2012-06-02 23:56:38 UTC
os-prober-1.53-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2012-06-09 00:03:13 UTC
os-prober-1.53-3.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 18 Fedora Update System 2012-06-11 00:00:06 UTC
os-prober-1.53-3.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.