Bug 825464
| Summary: | Don't add unnecessary dependency on dos2unix | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> | ||||
| Component: | python-bunch | Assignee: | Toshio Ernie Kuratomi <a.badger> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | rawhide | CC: | a.badger, mcepl | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-05-28 23:30:51 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
In the general case, it's not actually a goal of Fedora to rebuild on a minimal installation without support of things like mock. If you'd like it to be, feel free to bring it up as a draft to the FPC. In the dos2unix case specifically this has come up before and the FPC has said that either sed or dos2unix is fine. dos2unix is clearer to read so I've been preferring it recently. (In reply to comment #1) > In the general case, it's not actually a goal of Fedora to rebuild on a > minimal installation without support of things like mock. If you'd like it > to be, feel free to bring it up as a draft to the FPC. I am not talking about mock, but I just happen to work on a derivate from Fedora which didn't have dos2unix packaged. No problem, I could do rpmbuild --rebuild anytime, just that I thought that entia non sunt multiplicanda praeter necessitatem (Occham's razor), so that less packages is better than more. Anyway, your package, your choice. |
Created attachment 587020 [details] suggested patch Description of problem: Using dos2unix in .spec file is unnecessary and it adds useless dependency on another external package. Version-Release number of selected component (if applicable): python-bunch-1.0.1-1 How reproducible: 100% Steps to Reproduce: 1.Try to rebuild the package on a system with minimal installation 2. 3. Actual results: missing dependency on dos2unix package Expected results: we should prefer already available tools Additional info: