Bug 825464 - Don't add unnecessary dependency on dos2unix
Summary: Don't add unnecessary dependency on dos2unix
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: python-bunch
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Toshio Ernie Kuratomi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-05-26 16:12 UTC by Matěj Cepl
Modified: 2018-04-11 15:58 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2012-05-28 23:30:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
suggested patch (1013 bytes, patch)
2012-05-26 16:12 UTC, Matěj Cepl
no flags Details | Diff

Description Matěj Cepl 2012-05-26 16:12:50 UTC
Created attachment 587020 [details]
suggested patch

Description of problem:
Using dos2unix in .spec file is unnecessary and it adds useless dependency on another external package.

Version-Release number of selected component (if applicable):
python-bunch-1.0.1-1

How reproducible:
100%

Steps to Reproduce:
1.Try to rebuild the package on a system with minimal installation
2.
3.
  
Actual results:
missing dependency on dos2unix package

Expected results:
we should prefer already available tools

Additional info:

Comment 1 Toshio Ernie Kuratomi 2012-05-28 23:30:51 UTC
In the general case, it's not actually a goal of Fedora to rebuild on a minimal installation without support of things like mock.  If you'd like it to be, feel free to bring it up as a draft to the FPC.

In the dos2unix case specifically this has come up before and the FPC has said that either sed or dos2unix is fine.  dos2unix is clearer to read so I've been preferring it recently.

Comment 2 Matěj Cepl 2012-05-29 13:45:52 UTC
(In reply to comment #1)
> In the general case, it's not actually a goal of Fedora to rebuild on a
> minimal installation without support of things like mock.  If you'd like it
> to be, feel free to bring it up as a draft to the FPC.

I am not talking about mock, but I just happen to work on a derivate from Fedora which didn't have dos2unix packaged. No problem, I could do rpmbuild --rebuild anytime, just that I thought that entia non sunt multiplicanda praeter necessitatem (Occham's razor), so that less packages is better than more. Anyway, your package, your choice.


Note You need to log in before you can comment on or make changes to this bug.