Bug 826458

Summary: Gluster - Backend: Exception on adding a brick that is already assigned
Product: [Retired] oVirt Reporter: Daniel Paikov <dpaikov>
Component: ovirt-engine-coreAssignee: Kanagaraj <kmayilsa>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: acathrow, dyasny, hateya, iheim, mgoldboi, sankarshan, sesubram, shireesh, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: gluster
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-17 07:49:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 825285    
Attachments:
Description Flags
engine.log
none
vdsm.log none

Description Daniel Paikov 2012-05-30 09:01:13 UTC
Created attachment 587647 [details]
engine.log

Trying to add a brick that already belongs to an existing volume triggers an exception. Attaching engine.log and vdsm.log.

Comment 1 Daniel Paikov 2012-05-30 09:01:52 UTC
Created attachment 587648 [details]
vdsm.log

Comment 2 Selvasundaram 2012-06-03 13:57:24 UTC
Fix submitted on patch: http://gerrit.ovirt.org/4989

Comment 3 Daniel Paikov 2012-06-10 13:24:01 UTC
9xJun: No exception anymore, but the error shown to the user is still pretty ugly:

Error while executing action Create Gluster Volume: Volume create failed error: Brick: 10_35_64_205:/vol19 already in use return code: 255

Comment 4 Shireesh 2012-06-11 06:35:13 UTC
The first part of this message (Error while executing action Create Gluster Volume:) is a standard message when an action fails. The error description is:

Volume create failed
error: Brick: 10_35_64_205:/vol19 already in use
return code: 255

The newlines are eaten up when this is shown as HTML. I suggest to make sure that newlines are replaced with <br> tags or the error be displayed in a <pre> tag so that newlines are preserved on screen. The error will then look like:

Error while executing action Create Gluster Volume: Volume create failed
error: Brick: 10_35_64_205:/vol19 already in use
return code: 255

Does it look good to you?

Comment 5 Yaniv Kaul 2012-06-11 06:44:54 UTC
(In reply to comment #4)
> The first part of this message (Error while executing action Create Gluster
> Volume:) is a standard message when an action fails. The error description
> is:
> 
> Volume create failed
> error: Brick: 10_35_64_205:/vol19 already in use
> return code: 255
> 
> The newlines are eaten up when this is shown as HTML. I suggest to make sure
> that newlines are replaced with <br> tags or the error be displayed in a
> <pre> tag so that newlines are preserved on screen. The error will then look
> like:
> 
> Error while executing action Create Gluster Volume: Volume create failed

Should be 'Volume creation failed'

Comment 6 Daniel Paikov 2012-06-11 08:06:21 UTC
(In reply to comment #4)
> The first part of this message (Error while executing action Create Gluster
> Volume:) is a standard message when an action fails. The error description
> is:
> 
> Volume create failed
> error: Brick: 10_35_64_205:/vol19 already in use
> return code: 255
> 
> The newlines are eaten up when this is shown as HTML. I suggest to make sure
> that newlines are replaced with <br> tags or the error be displayed in a
> <pre> tag so that newlines are preserved on screen. The error will then look
> like:
> 
> Error while executing action Create Gluster Volume: Volume create failed
> error: Brick: 10_35_64_205:/vol19 already in use
> return code: 255
> 
> Does it look good to you?

Yes, please add <br> tags and change the underscores back to dots in the IP address to make the error more readable.

Comment 7 Shireesh 2012-06-11 09:02:30 UTC
We will introduce the newlines. However the underscores in brick server ip is coming from glusterfs, so we should't change that. If at all, it should be fixed in glusterfs.

Comment 8 Kanagaraj 2012-06-11 14:25:35 UTC
All the new line characters(\n) will be replaced with <br/> tag before showing the error message.

Patch : http://gerrit.ovirt.org/#/c/5245/

Comment 9 Daniel Paikov 2012-06-18 08:59:19 UTC
Checked on rhsc-2.0.techpreview1-0.scratch.