Created attachment 587647 [details] engine.log Trying to add a brick that already belongs to an existing volume triggers an exception. Attaching engine.log and vdsm.log.
Created attachment 587648 [details] vdsm.log
Fix submitted on patch: http://gerrit.ovirt.org/4989
9xJun: No exception anymore, but the error shown to the user is still pretty ugly: Error while executing action Create Gluster Volume: Volume create failed error: Brick: 10_35_64_205:/vol19 already in use return code: 255
The first part of this message (Error while executing action Create Gluster Volume:) is a standard message when an action fails. The error description is: Volume create failed error: Brick: 10_35_64_205:/vol19 already in use return code: 255 The newlines are eaten up when this is shown as HTML. I suggest to make sure that newlines are replaced with <br> tags or the error be displayed in a <pre> tag so that newlines are preserved on screen. The error will then look like: Error while executing action Create Gluster Volume: Volume create failed error: Brick: 10_35_64_205:/vol19 already in use return code: 255 Does it look good to you?
(In reply to comment #4) > The first part of this message (Error while executing action Create Gluster > Volume:) is a standard message when an action fails. The error description > is: > > Volume create failed > error: Brick: 10_35_64_205:/vol19 already in use > return code: 255 > > The newlines are eaten up when this is shown as HTML. I suggest to make sure > that newlines are replaced with <br> tags or the error be displayed in a > <pre> tag so that newlines are preserved on screen. The error will then look > like: > > Error while executing action Create Gluster Volume: Volume create failed Should be 'Volume creation failed'
(In reply to comment #4) > The first part of this message (Error while executing action Create Gluster > Volume:) is a standard message when an action fails. The error description > is: > > Volume create failed > error: Brick: 10_35_64_205:/vol19 already in use > return code: 255 > > The newlines are eaten up when this is shown as HTML. I suggest to make sure > that newlines are replaced with <br> tags or the error be displayed in a > <pre> tag so that newlines are preserved on screen. The error will then look > like: > > Error while executing action Create Gluster Volume: Volume create failed > error: Brick: 10_35_64_205:/vol19 already in use > return code: 255 > > Does it look good to you? Yes, please add <br> tags and change the underscores back to dots in the IP address to make the error more readable.
We will introduce the newlines. However the underscores in brick server ip is coming from glusterfs, so we should't change that. If at all, it should be fixed in glusterfs.
All the new line characters(\n) will be replaced with <br/> tag before showing the error message. Patch : http://gerrit.ovirt.org/#/c/5245/
Checked on rhsc-2.0.techpreview1-0.scratch.