Bug 826563
| Summary: | Review Request: fuelmanager - keep track of your fuel mileage and consumption | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | kc8hfi |
| Component: | Package Review | Assignee: | Nick Bebout <nb> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mail, nb, notting, package-review, pingou, sanjay.ankur |
| Target Milestone: | --- | Flags: | nb:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-06 21:26:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
kc8hfi
2012-05-30 14:00:45 UTC
The SRPM link is incorrect, it should be: http://sourceforge.net/projects/fuelmanager/files/fuelmanager-0.3.6-5.fc15.src.rpm/download Spec URL: http://fedorapeople.org/~kc8hfi/fuelmanager.spec SRPM URL: http://fedorapeople.org/~kc8hfi/fuelmanager-0.3.6-5.fc15.src.rpm Just some quick comments: - You are mixing macro and variable style - The numbering in your changelog needs a reset when updating the package - defattr is no longer needed - hicolor-icon-theme is a requirement - Working with wildcards in your %files section will make your life easier in the future when updating the package New Spec URL: http://kc8hfi.fedorapeople.org/fuelmanager.spec New SRPM URL: http://kc8hfi.fedorapeople.org/fuelmanager-0.3.7-1.fc17.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4184879 1. removed the defattr 2. added hicolor-icon-theme to build requirements 3. using more wildcards in %files I think I've moved everything to one style, instead of mixing macro and variable. Please fix your sources, the md5sum of the tarball in your srpm and the file at the url in Source0 do not match. Everything else looks good now, except for you don't need to add gcc-c++ to BuildRequires, it's on the list of exceptions. With these changes, this package is APPROVED. I have sponsored you into the packager group, congratulations! New Package SCM Request ======================= Package Name: fuelmanager Short Description: keep track of fuel mileage Owners: kc8hfi Branches: f16 f17 InitialCC: SCM request package name and Bug summary package name don't match, please fix. Preferably fuelmanager. New Package SCM Request ======================= Package Name: fuelmanager Short Description: keep track of fuel mileage Owners: kc8hfi Branches: f16 f17 InitialCC: (In reply to comment #5) > 2. added hicolor-icon-theme to build requirements Your package requires 'hicolor-icon-theme' because of the directory ownership. 'hicolor-icon-theme' is not a BR Git done (by process-git-requests). fuelmanager-0.3.7-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fuelmanager-0.3.7-2.fc17 fuelmanager-0.3.7-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fuelmanager-0.3.7-2.fc16 fuelmanager-0.3.7-2.fc17 has been pushed to the Fedora 17 testing repository. fuelmanager-0.3.7-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/fuelmanager-0.3.7-3.fc17 fuelmanager-0.3.7-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/fuelmanager-0.3.7-3.fc16 fuelmanager-0.3.7-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. fuelmanager-0.3.7-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |