Red Hat Bugzilla – Bug 826563
Review Request: fuelmanager - keep track of your fuel mileage and consumption
Last modified: 2012-07-19 05:04:46 EDT
Spec URL: http://sourceforge.net/projects/fuelmanager/files/fuelmanager.spec/download
SRPM URL: http://sourceforge.net/projects/fuelmanager/files/fuelmanager-0.3.6-5.fc16.src.rpm/download
Description: This is a handy fuel manager application. It keeps track of 4 things, miles, gallons, cost, and the date of each fillup. The program will generate monthly and yearly summaries of miles driven, cost of fuel, how many gallons, and fuel mileage.
Fedora Account System Username:kc8hfi
This is my first package and I need a sponsor.
The SRPM link is incorrect, it should be:
Spec URL: http://fedorapeople.org/~kc8hfi/fuelmanager.spec
SRPM URL: http://fedorapeople.org/~kc8hfi/fuelmanager-0.3.6-5.fc15.src.rpm
Just some quick comments:
- You are mixing macro and variable style
- The numbering in your changelog needs a reset when updating the package
- defattr is no longer needed
- hicolor-icon-theme is a requirement
- Working with wildcards in your %files section will make your life easier in the future when updating the package
New Spec URL: http://kc8hfi.fedorapeople.org/fuelmanager.spec
New SRPM URL: http://kc8hfi.fedorapeople.org/fuelmanager-0.3.7-1.fc17.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=4184879
1. removed the defattr
2. added hicolor-icon-theme to build requirements
3. using more wildcards in %files
I think I've moved everything to one style, instead of mixing macro and variable.
Please fix your sources, the md5sum of the tarball in your srpm and the file at the url in Source0 do not match.
Everything else looks good now, except for you don't need to add gcc-c++ to BuildRequires, it's on the list of exceptions.
With these changes, this package is APPROVED.
I have sponsored you into the packager group, congratulations!
New Package SCM Request
Package Name: fuelmanager
Short Description: keep track of fuel mileage
Branches: f16 f17
SCM request package name and Bug summary package name don't match, please
fix. Preferably fuelmanager.
(In reply to comment #5)
> 2. added hicolor-icon-theme to build requirements
Your package requires 'hicolor-icon-theme' because of the directory ownership. 'hicolor-icon-theme' is not a BR
Git done (by process-git-requests).
fuelmanager-0.3.7-2.fc17 has been submitted as an update for Fedora 17.
fuelmanager-0.3.7-2.fc16 has been submitted as an update for Fedora 16.
fuelmanager-0.3.7-2.fc17 has been pushed to the Fedora 17 testing repository.
fuelmanager-0.3.7-3.fc17 has been submitted as an update for Fedora 17.
fuelmanager-0.3.7-3.fc16 has been submitted as an update for Fedora 16.
fuelmanager-0.3.7-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report.
fuelmanager-0.3.7-3.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report.