Bug 827008 (libkcddb)

Summary:	Review Request: libkcddb - A KDE CDDB retrieval library
Product:	[Fedora] Fedora	Reporter:	Jaroslav Reznik <jreznik>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	kevin, notting, package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-09 00:01:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997, 830362

Description Jaroslav Reznik 2012-05-31 12:16:44 UTC

Spec URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb-4.8.80-1.fc16.src.rpm
Description: A KDE CDDB retrieval library.
Fedora Account System Username: jreznik

http://koji.fedoraproject.org/koji/taskinfo?taskID=4116686

rpmlint libkcddb-4.8.80-1.fc16.x86_64.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

rpmlint libkcddb-4.8.80-1.fc16.src.rpm 
libkcddb.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/unstable/4.8.80/src/libkcddb-4.8.80.tar.xz <urlopen error ftp error: 550 Failed to change directory.>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

(pre packages)

Comment 1 Rex Dieter 2012-05-31 19:41:34 UTC

The only thing I see really is to fixup conflicts:

1.
Conflicts:  kdemultimedia-libs < 6:4.8.80-1 
and -devel:
Conflicts:  kdemultimedia-devel < 6:4.8.80-1


otherwise, the rest is a relatively simple library

naming: ok

sources: ok

licensing: ok

scriptlets: ok

macros: ok


APPROVED (item 1 can be done post review, prior to building)

Comment 2 Kevin Kofler 2012-05-31 20:02:28 UTC

BuildRequires:  kdelibs-devel >= %{version}
is not going to work (missing Epoch), please use:
BuildRequires:  kdelibs4-devel >= %{version}
instead. (The virtual Provides has no Epoch, among other reasons.)

Comment 3 Jaroslav Reznik 2012-06-04 11:44:45 UTC

Fixed

Spec URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb.spec
SRPM URL: http://rezza.hofyland.cz/fedora/packages/kdemultimedia/libkcddb-4.8.80-1.fc16.src.rpm

Comment 4 Jaroslav Reznik 2012-06-04 11:46:26 UTC

New Package SCM Request
=======================
Package Name: libkcddb
Short Description: A KDE CDDB retrieval library
Owners: jreznik ltinkl rdieter than kkofler
Branches: f17
InitialCC:

Comment 5 Gwyn Ciesla 2012-06-04 12:08:55 UTC

Git done (by process-git-requests).

Comment 6 Rex Dieter 2012-06-09 00:01:33 UTC

imported