Bug 827012

Summary: 3.1 [VDSM] beta1 [Hot plug NIC] hotplug NIC stops working after VM live snapshot is created
Product: Red Hat Enterprise Linux 6 Reporter: Martin Pavlik <mpavlik>
Component: vdsmAssignee: Igor Lvovsky <ilvovsky>
Status: CLOSED DUPLICATE QA Contact: Martin Pavlik <mpavlik>
Severity: high Docs Contact:
Priority: high    
Version: 6.3CC: abaron, bazulay, danken, dyasny, gklein, iheim, lpeer, mkenneth, Rhev-m-bugs, yeylon, ykaul
Target Milestone: rc   
Target Release: 6.4   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-13 08:13:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 581266, 833637, 835390, 835392    
Attachments:
Description Flags
vdsm.log + engine.log
none
libvirt.log
none
screenshot 1 none

Description Martin Pavlik 2012-05-31 12:30:33 UTC
Created attachment 588066 [details]
vdsm.log + engine.log

Description of problem:
It is not possible to hotplug/hotunplug NIC from VM after VM snapshot is created

Version-Release number of selected component (if applicable):
oVirt Enterprise Virtualization Engine Manager Version: 3.1.0_0001-11.el6ev 

How reproducible:
100%

Steps to Reproduce:
1) create VM with windows7 (install virtIO driver for NIC)
2) add 2 NIC to VM (1 activated, 1 deactivated)
3) start VM
4) create snapshot of running VM
5) try to decativate active NIC
  
Actual results:
hotplug NIC stops working after VM snapshot is created

Expected results:
hotplug NIC should be working without error after VM snapshot is created

Additional info:
No error is reported in events

engine.log
2012-05-31 14:17:42,925 ERROR [org.ovirt.engine.core.vdsbroker.VDSCommandBase] (pool-10-thread-47) [289b8ea0] Command HotUnplugNicVDS execution failed. Exception: XmlRpcRunTimeException: java.util.concurrent.ExecutionException: java.lang.reflect.InvocationTargetException
2012-05-31 14:17:42,926 INFO  [org.ovirt.engine.core.vdsbroker.vdsbroker.HotUnplugNicVDSCommand] (pool-10-thread-47) [289b8ea0] FINISH, HotUnplugNicVDSCommand, log id: 28771028
2012-05-31 14:17:42,927 ERROR [org.ovirt.engine.core.bll.HotPlugUnplugVmNicCommand] (pool-10-thread-47) [289b8ea0] Command org.ovirt.engine.core.bll.HotPlugUnplugVmNicCommand throw Vdc Bll exception. With error message VdcBLLException: org.ovirt.engine.core.vdsbroker.xmlrpc.XmlRpcRunTimeException: java.util.concurrent.ExecutionException: java.lang.reflect.InvocationTargetException

Comment 1 Martin Pavlik 2012-05-31 12:35:50 UTC
Created attachment 588067 [details]
libvirt.log

Comment 2 Martin Pavlik 2012-05-31 12:36:12 UTC
Created attachment 588068 [details]
screenshot 1

Comment 7 Mike Kolesnik 2012-08-09 08:22:32 UTC
There are two issues here, both should be solved on VDSM side:

 1. The returned value contains a dictionary for key 'vmList' which contains a field (in a device sub-dictionary) with value None which causes XML RPC parser to crash at engine side.
 2. The engine does not look at the vmList dictionary in any of the plug/unplug (nic/disk) actions, so not returning it will definitely solve the reported bug.

Please fix as you deem correct on VDSM side.

Comment 9 Dan Kenigsberg 2012-08-13 08:13:37 UTC
Mike: the None element is mirror/mirrorPath just as in bug 842771

*** This bug has been marked as a duplicate of bug 842771 ***