Bug 827730
| Summary: | Review Request: trac-code-comments-plugin - Trac plugin for code comments and sending them to tickets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rick Elrod <relrod> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-26 21:27:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rick Elrod
2012-06-02 17:22:57 UTC
Kevin has agreed to review this. CCing. I'll try and review this sometime this weekend. ;) OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz.new OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The release seems a bit off here. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages for more info. If this is a prerelease of 1.2.0, I'd suggest: 0.1.alpha2 or 0.1.20120601gitb260714 (if there's no tag/release of alpha2) 2. Might ask upstream to include copies of the licenses it's under. (non blocker) 3. rpmlint says: trac-code-comments-plugin.src: W: invalid-url Source0: Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Which can be ignored. *Updated the 'Release' field. * Filed #18 upstream asking if they'd mind including a LICENSE file: https://github.com/Automattic/trac-code-comments-plugin/issues/18 Files are in the same locations: Spec URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin.spec SRPM URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin-1.2.0-alpha2.20120601gitb260714.fc18.src.rpm Thanks! oops, I lied New SRPM: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc18.src.rpm Looks good. I see no further blockers, so this package is APPROVED. New Package SCM Request ======================= Package Name: trac-code-comments-plugin Short Description: Trac plugin for code comments and sending them to tickets Owners: codeblock Branches: f16 f17 el6 InitialCC: Git done (by process-git-requests). trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16 trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17 trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been pushed to the Fedora EPEL 6 testing repository. trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17 has been pushed to the Fedora 17 stable repository. trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16 has been pushed to the Fedora 16 stable repository. trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been pushed to the Fedora EPEL 6 stable repository. |