Hide Forgot
Spec URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin.spec SRPM URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin-1.2.0-alpha2.20120601gitb260714.fc18.src.rpm Description: This plugin allows you to leave comments on top of files, change sets, and attachments. Once you've added all of your comments, you can send them to tickets. These include links to these comments and their description. Fedora Account System Username: codeblock Clean rpmlint, minus one warning because of how the source was obtained (upstream is a tarball downloaded from github). [ricky@t520 rpmbuild]$ rpmlint SRPMS/trac-code-comments-plugin-1.2.0-alpha2.20120601gitb260714.fc18.src.rpm trac-code-comments-plugin.src: W: invalid-url Source0: Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [ricky@t520 rpmbuild]$ rpmlint RPMS/noarch/trac-code-comments-plugin-1.2.0-alpha2.20120601gitb260714.fc18.noarch.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Note that this does have several javascript libraries bundled with it with varying licenses. I've included (in %doc) a LICENSING_BREAKDOWN file which shows what is licensed differently from the plugin itself, as instructed here: http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios Happy to clarify any of the licensing related things if I need to (or communicate with upstream to do so).
Kevin has agreed to review this. CCing.
I'll try and review this sometime this weekend. ;)
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 85b5ad87cb14d4d64f96050a12118d95 Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz.new OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. The release seems a bit off here. See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages for more info. If this is a prerelease of 1.2.0, I'd suggest: 0.1.alpha2 or 0.1.20120601gitb260714 (if there's no tag/release of alpha2) 2. Might ask upstream to include copies of the licenses it's under. (non blocker) 3. rpmlint says: trac-code-comments-plugin.src: W: invalid-url Source0: Automattic-trac-code-comments-plugin-v1.0.1-52-gb260714.tar.gz 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Which can be ignored.
*Updated the 'Release' field. * Filed #18 upstream asking if they'd mind including a LICENSE file: https://github.com/Automattic/trac-code-comments-plugin/issues/18 Files are in the same locations: Spec URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin.spec SRPM URL: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin-1.2.0-alpha2.20120601gitb260714.fc18.src.rpm Thanks!
oops, I lied New SRPM: http://codeblock.fedorapeople.org/packages/trac-code-comments-plugin/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc18.src.rpm
Looks good. I see no further blockers, so this package is APPROVED.
New Package SCM Request ======================= Package Name: trac-code-comments-plugin Short Description: Trac plugin for code comments and sending them to tickets Owners: codeblock Branches: f16 f17 el6 InitialCC:
Git done (by process-git-requests).
trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16
trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17
trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6
trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been pushed to the Fedora EPEL 6 testing repository.
trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc17 has been pushed to the Fedora 17 stable repository.
trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.fc16 has been pushed to the Fedora 16 stable repository.
trac-code-comments-plugin-1.2.0-0.1.20120601gitb260714.el6 has been pushed to the Fedora EPEL 6 stable repository.