Bug 828998
Summary: | Review Request: drupal6-media_vimeo - Vimeo Video Module for Drupal6 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Anderson Silva <ansilva> | ||||||
Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | notting, package-review, shawn | ||||||
Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2013-04-01 22:25:46 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Anderson Silva
2012-06-05 18:10:45 UTC
After quick review, missing "drupal6-emvideo" dependency (In reply to comment #1) > After quick review, missing "drupal6-emvideo" dependency Nevermind! I missed that emvideo was a sub-module of emfield. I'm hoping to get the drupal packaging spec updated so virtual provides should be listed. So, are you ok with this package? Do you need me to do something for it? Created attachment 701894 [details] drupal6-media_vimeo-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 828998 Created attachment 701895 [details]
phpci.log
===== SHOULD items ===== > [!]: If the source package does not include license text(s) as a separate file > from upstream, the packager SHOULD query upstream to include it. > [!]: Package does not include license text files separate from upstream. I believe this is because of a license update in the actual license file? Has upstream been made aware of the needed update? > [!]: Packages should try to preserve timestamps of original installed files. Please consider adding the "-p" (or "--preserve-timestamps") flag to your install command. No blockers. ===== APPROVED ===== New Package SCM Request ======================= Package Name: drupal6-media_vimeo Short Description: This module adds support for videos by the Vimeo provider to Embedded Media Field Owners: siwinski afsilva Branches: f17 f18 f19 el6 InitialCC: Git done (by process-git-requests). drupal6-media_vimeo-1.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.fc17 drupal6-media_vimeo-1.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.fc18 drupal6-media_vimeo-1.1-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.el6 Package Change Request ====================== Package Name: drupal6-media_vimeo New Branches: el5 Owners: ansilva siwinski InitialCC: Adding el5 branch to follow most other drupal6 packages. Git done (by process-git-requests). drupal6-media_vimeo-1.1-3.el6 has been pushed to the Fedora EPEL 6 testing repository. drupal6-media_vimeo-1.1-3.fc17 has been pushed to the Fedora 17 stable repository. drupal6-media_vimeo-1.1-3.fc18 has been pushed to the Fedora 18 stable repository. |