Bug 828998 - Review Request: drupal6-media_vimeo - Vimeo Video Module for Drupal6
Summary: Review Request: drupal6-media_vimeo - Vimeo Video Module for Drupal6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Shawn Iwinski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-05 18:10 UTC by Anderson Silva
Modified: 2013-04-01 22:32 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-04-01 22:25:46 UTC
shawn: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)
drupal6-media_vimeo-review.txt (6.54 KB, text/plain)
2013-02-24 05:18 UTC, Shawn Iwinski
no flags Details
phpci.log (11.97 KB, text/x-log)
2013-02-24 05:18 UTC, Shawn Iwinski
no flags Details

Description Anderson Silva 2012-06-05 18:10:45 UTC
Spec URL: http://people.redhat.com/~ansilva/drupal6-media_vimeo.spec
SRPM URL: http://people.redhat.com/~ansilva/drupal6-media_vimeo-1.1-3.fc16.src.rpm
Description: This module adds support for videos by the Vimeo provider to Embedded Media Field
Fedora Account System Username: afsilva

Comment 1 Shawn Iwinski 2013-01-26 18:55:29 UTC
After quick review, missing "drupal6-emvideo" dependency

Comment 2 Shawn Iwinski 2013-01-26 19:03:57 UTC
(In reply to comment #1)
> After quick review, missing "drupal6-emvideo" dependency

Nevermind!  I missed that emvideo was a sub-module of emfield.  I'm hoping to get the drupal packaging spec updated so virtual provides should be listed.

Comment 3 Anderson Silva 2013-02-13 14:35:28 UTC
So, are you ok with this package? Do you need me to do something for it?

Comment 4 Shawn Iwinski 2013-02-24 05:18:08 UTC
Created attachment 701894 [details]
drupal6-media_vimeo-review.txt

Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --bug 828998

Comment 5 Shawn Iwinski 2013-02-24 05:18:40 UTC
Created attachment 701895 [details]
phpci.log

Comment 6 Shawn Iwinski 2013-02-24 05:23:30 UTC
===== SHOULD items =====
> [!]: If the source package does not include license text(s) as a separate file
>      from upstream, the packager SHOULD query upstream to include it.
> [!]: Package does not include license text files separate from upstream.

I believe this is because of a license update in the actual license file?  Has upstream been made aware of the needed update?

> [!]: Packages should try to preserve timestamps of original installed files.

Please consider adding the "-p" (or "--preserve-timestamps") flag to your install command.



No blockers.

===== APPROVED =====

Comment 7 Anderson Silva 2013-03-22 16:41:40 UTC
New Package SCM Request
=======================
Package Name: drupal6-media_vimeo
Short Description: This module adds support for videos by the Vimeo provider to Embedded Media Field
Owners: siwinski afsilva
Branches: f17 f18 f19 el6
InitialCC:

Comment 8 Gwyn Ciesla 2013-03-22 17:24:21 UTC
Git done (by process-git-requests).

Comment 9 Fedora Update System 2013-03-22 19:34:03 UTC
drupal6-media_vimeo-1.1-3.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.fc17

Comment 10 Fedora Update System 2013-03-22 19:34:40 UTC
drupal6-media_vimeo-1.1-3.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.fc18

Comment 11 Fedora Update System 2013-03-22 20:29:49 UTC
drupal6-media_vimeo-1.1-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/drupal6-media_vimeo-1.1-3.el6

Comment 12 Shawn Iwinski 2013-03-23 04:51:37 UTC
Package Change Request
======================
Package Name: drupal6-media_vimeo
New Branches: el5
Owners: ansilva siwinski
InitialCC: 

Adding el5 branch to follow most other drupal6 packages.

Comment 13 Gwyn Ciesla 2013-03-23 13:08:59 UTC
Git done (by process-git-requests).

Comment 14 Fedora Update System 2013-03-23 18:18:33 UTC
drupal6-media_vimeo-1.1-3.el6 has been pushed to the Fedora EPEL 6 testing repository.

Comment 15 Fedora Update System 2013-04-01 22:25:48 UTC
drupal6-media_vimeo-1.1-3.fc17 has been pushed to the Fedora 17 stable repository.

Comment 16 Fedora Update System 2013-04-01 22:32:50 UTC
drupal6-media_vimeo-1.1-3.fc18 has been pushed to the Fedora 18 stable repository.


Note You need to log in before you can comment on or make changes to this bug.