Bug 829019
| Summary: | Review Request: xorg-x11-drv-omap - X driver for omapdrm driver | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Gilmore <dennis> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | herrold, notting, package-review, pbrobinson |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-08 09:42:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 245418 | ||
|
Description
Dennis Gilmore
2012-06-05 19:19:10 UTC
I'll go ahead and review this. Look for a full review later today. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (MIT) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: (git checkout. diffs match) OK - Package needs ExcludeArch OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. (non blocker): Might include the AUTHORS file as a doc. 2. rpmlint says: xorg-x11-drv-omap.armv5tel: W: spelling-error Summary(en_US) drm -> rm, dram, dorm xorg-x11-drv-omap.armv5tel: W: spelling-error %description -l en_US drm -> rm, dram, dorm xorg-x11-drv-omap.armv5tel: W: obsolete-not-provided xorg-x11-drv-omapfb xorg-x11-drv-omap.armv7hl: W: spelling-error Summary(en_US) drm -> rm, dram, dorm xorg-x11-drv-omap.armv7hl: W: spelling-error %description -l en_US drm -> rm, dram, dorm xorg-x11-drv-omap.armv7hl: W: obsolete-not-provided xorg-x11-drv-omapfb xorg-x11-drv-omap.src: W: spelling-error Summary(en_US) drm -> rm, dram, dorm xorg-x11-drv-omap.src: W: spelling-error %description -l en_US drm -> rm, dram, dorm xorg-x11-drv-omap.src:29: W: unversioned-explicit-obsoletes xorg-x11-drv-omapfb xorg-x11-drv-omap.src: W: invalid-url Source0: xf86-video-omap.tar.bz2 5 packages and 0 specfiles checked; 0 errors, 10 warnings. all can be ignored. I see no blockers here, so this package is APPROVED. New Package SCM Request ======================= Package Name: xorg-x11-drv-omap Short Description: X.Org X11 omapdrm driver Owners: ausil pbrobinson Branches: f17 InitialCC: Git done (by process-git-requests). Built and tested |