Bug 831272

Summary: remove all attempts at pluralization to fix i18n messages
Product: [Other] RHQ Project Reporter: John Mazzitelli <mazz>
Component: Core UIAssignee: Jay Shaughnessy <jshaughn>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.4CC: hrupp, jshaughn
Target Milestone: ---   
Target Release: RHQ 4.5.0   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-01 10:05:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description John Mazzitelli 2012-06-12 15:59:16 UTC
This pluralization code breaks i18n and forces the message to always be part english even if the locale isn't:

protected String getDataTypeName() {  return "item";  }
protected String getDataTypeNamePlural() {  return "items";  }
protected String getDeleteConfirmMessage() {   return MSG.common_msg_deleteConfirm(getDataTypeNamePlural());   }

We need to remove that and all usages of:

org.rhq.enterprise.gui.coregui.client.components.table.Table.getDataTypeNamePlural()

and related methods.

Comment 1 Jay Shaughnessy 2012-06-15 19:56:52 UTC
master commit 350b123ae5afb4248eb2936656744112c3950359
Get rid of the bogus message construction. Also, fix up some I18N stuff.

Comment 2 Heiko W. Rupp 2013-09-01 10:05:18 UTC
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.