Bug 831272 - remove all attempts at pluralization to fix i18n messages
Summary: remove all attempts at pluralization to fix i18n messages
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Core UI
Version: 4.4
Hardware: All
OS: All
medium
medium
Target Milestone: ---
: RHQ 4.5.0
Assignee: Jay Shaughnessy
QA Contact: Mike Foley
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-06-12 15:59 UTC by John Mazzitelli
Modified: 2013-09-01 10:05 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2013-09-01 10:05:18 UTC
Embargoed:

Attachments (Terms of Use)

Description John Mazzitelli 2012-06-12 15:59:16 UTC 
This pluralization code breaks i18n and forces the message to always be part english even if the locale isn't:

protected String getDataTypeName() {  return "item";  }
protected String getDataTypeNamePlural() {  return "items";  }
protected String getDeleteConfirmMessage() {   return MSG.common_msg_deleteConfirm(getDataTypeNamePlural());   }

We need to remove that and all usages of:

org.rhq.enterprise.gui.coregui.client.components.table.Table.getDataTypeNamePlural()

and related methods.
Comment 1 Jay Shaughnessy 2012-06-15 19:56:52 UTC 
master commit 350b123ae5afb4248eb2936656744112c3950359
Get rid of the bogus message construction. Also, fix up some I18N stuff.
Comment 2 Heiko W. Rupp 2013-09-01 10:05:18 UTC 
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.
Note You need to log in before you can comment on or make changes to this bug.