Bug 831491

Summary:	Review Request: php-zmq - PHP 0MQ/zmq/zeromq extension
Product:	[Fedora] Fedora	Reporter:	Ralph Bean <rbean>
Component:	Package Review	Assignee:	Gwyn Ciesla <gwync>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	gwync, notting, package-review
Target Milestone:	---	Flags:	gwync: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-07-09 01:55:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ralph Bean 2012-06-13 06:38:59 UTC

Spec URL: http://threebean.org/rpm/php-zmq.spec
SRPM URL: http://threebean.org/rpm/php-zmq-0.6.0-2.20120613git516bd6f.fc17.src.rpm
Description: PHP extension for the 0MQ/zmq/zeromq messaging system
Fedora Account System Username: ralph




rpmlint output:
--- devel/php-zmq ‹master* ⁇› » rpmlint php-zmq.spec ~/rpmbuild/SRPMS/php-zmq-0.6.0-2.20120613git516bd6f.fc17.src.rpm 
php-zmq.spec: W: invalid-url Source0: php-zmq-0.6.0-2.20120613git516bd6f.tar.gz
php-zmq.src: W: spelling-error Summary(en_US) zeromq -> zero
php-zmq.src: W: spelling-error %description -l en_US zeromq -> zero
php-zmq.src: W: invalid-url Source0: php-zmq-0.6.0-2.20120613git516bd6f.tar.gz
1 packages and 1 specfiles checked; 0 errors, 4 warnings.
--- devel/php-zmq ‹master* ⁇› » rpmlint /var/lib/mock/fedora-17-x86_64/result/*.rpm                                  
php-zmq.src: W: spelling-error Summary(en_US) zeromq -> zero
php-zmq.src: W: spelling-error %description -l en_US zeromq -> zero
php-zmq.src: W: invalid-url Source0: php-zmq-0.6.0-2.20120613git516bd6f.tar.gz
php-zmq.x86_64: W: private-shared-object-provides /usr/lib64/php/modules/zmq.so zmq.so()(64bit)
3 packages and 0 specfiles checked; 0 errors, 4 warnings.



koji f17 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4157397
koji el6 - http://koji.fedoraproject.org/koji/taskinfo?taskID=4157400

Comment 1 Gwyn Ciesla 2012-06-13 16:47:26 UTC

- rpmlint checks return:

See above.  All ok except for the private-shared-object-provides.

- package meets naming guidelines
- package meets packaging guidelines
- license ( BSD ) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
FIX no unnecessary BR  No need to BR gcc
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

Otherwise it looks good, just the spurious gcc BR and the provides.

Comment 2 Gwyn Ciesla 2012-06-13 16:50:27 UTC

Oh, also License should be BSD and PHP, run-tests.php is PHP.

Comment 3 Ralph Bean 2012-06-14 00:34:37 UTC

A new release:

SPEC: http://threebean.org/rpm/php-zmq.spec
SRPM: http://threebean.org/rpm/php-zmq-0.6.0-3.20120613git516bd6f.fc17.src.rpm 

Includes:

 - Updated License to BSD and PHP.
 - Removed spurious gcc BuildRequires.
 - Attempt to fix private-shared-object-provides.

I've tried a number of different ways now and I just can't figure out the private-shared-object-provides rpmlint warning.  I'm stumped; if you have any suggestions, please let me know.

Comment 4 Gwyn Ciesla 2012-06-14 14:18:57 UTC

Add:

%filter_from_provides /^zmq.so/d
%filter_setup


To the beginning.

https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering

Comment 5 Ralph Bean 2012-06-14 19:51:53 UTC

That did it!  Thanks for the help and the review.

SPEC: http://threebean.org/rpm/php-zmq.spec
SRPM: http://threebean.org/rpm/php-zmq-0.6.0-4.20120613git516bd6f.fc17.src.rpm

Comment 6 Gwyn Ciesla 2012-06-15 13:05:46 UTC

Anytime.  APPROVED.

Comment 7 Ralph Bean 2012-06-15 15:04:44 UTC

New Package SCM Request
=======================
Package Name: php-zmq
Short Description: PHP 0MQ/zmq/zeromq extension
Owners: ralph
Branches: f17 el6
InitialCC:

Comment 8 Gwyn Ciesla 2012-06-15 15:05:47 UTC

Git done (by process-git-requests).

Comment 9 Ralph Bean 2012-06-21 16:35:03 UTC

I forgot to mark the bug number in bodhi, but this has been pushed to testing.

https://admin.fedoraproject.org/updates/FEDORA-2012-9583/php-zmq-0.6.0-4.20120613git516bd6f.fc17
https://admin.fedoraproject.org/updates/FEDORA-EPEL-2012-6182/php-zmq-0.6.0-4.20120613git516bd6f.el6