Bug 835089
| Summary: | Review Request: Script-Tools | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Simon A. Erat <erat.simon> | ||||||||||||||||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||||||||||||||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||||
| Version: | rawhide | CC: | notting, package-review, rdieter, sanjay.ankur | ||||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||
| Hardware: | noarch | ||||||||||||||||||||||
| OS: | Linux | ||||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||
| Last Closed: | 2013-08-13 11:25:08 UTC | Type: | Bug | ||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Simon A. Erat
2012-06-25 14:02:52 UTC
Created attachment 594204 [details]
Spec-File
Created attachment 594205 [details]
F17-src.rpm
Created attachment 594263 [details]
Spec-File
Created attachment 594264 [details]
F17-src.rpm
Changed specfile:
Requires: bash
Conflicts: %{name} >= %{version}-%{release}
------------
Upstream: http://sea.hostingsociety.com/dev
Written a small part about the dev section in README.
Some additions: * All of the code is self written. * The Script-Tools can run from everywhere, however, by default its sym-linking to /usr/share/script-tools. That is so it can be executed from an usb-stick, usb-harddisk, CD/DvD. For that reason it stores the user data in $HOME/bin/$USER-libs/*. What is on the list todo, but with low priority, to use your own listfiles for the setup of your system from minimal to GUI. Created attachment 594519 [details]
Spec-File
Created attachment 594520 [details]
F17-src.rpm
Fixed some errors in specfile with help from IRC. Koji builds ----------- F16: https://koji.fedoraproject.org/koji/taskinfo?taskID=4197370 Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=4197211 Update: ------- Since the package is very small, I reconsidered to make the rpm not relocatable. Further, as i consider it alpha, changed the specfile accordingly. Upstream: --------- Spec: http://sea.hostingsociety.com/dev/script-tools.spec SRPM: http://sea.hostingsociety.com/dev/script-tools-0.6.3-4.fc17.alpha1.src.rpm Reviewing foreign package: https://bugzilla.redhat.com/show_bug.cgi?id=835099 Some notes:
Relocatable packages aren't permitted in Fedora anyway.
The versioning doesn't meet the guidelines; there are only very limited circumstances where something is permitted after the dist tag. If your package is a prerelease of what will eventually be called 0.6.3, it should be 0.6.3-0.4.alpha1%{?dist}. Note that the release is less than 1 because it's a prerelease version, and when 0.6.3 is released you can just use 0.6.3-1%{?dist}.
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages
You really must untar your source in %prep, not in %install.
If you do not intend to support RHEL5, you do not need BuildRoot, %clean or the first line of %install. Nothing needs the %defattr line in %files.
rpmlint gives a really large number of non-executable script warnings, and some really odd stuff like
script-tools.noarch: W: dangling-symlink
/usr/share/script-tools/scripts/simon /home/simon/bin/simon-scripts
You... can't refer to your home directory in an rpm spec file which will be built and installed on systemd that don't have your home directory.
The last changelog entry doesn't match the package version, and your changelog entries don't follow one of the formats specified in the packaging guidelines: http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
I can't figure out how users are supposed to run any of these scripts as nothing gets installed anywhere in the path.
The referene to my homedir is created dynamicly, as soon a directory like:
$HOME/bin/$USER-scripts exists, and will be symlinked to $stDir/scripts/$USER.
The cause for this is to enable users to easy add (implement, use of Script-tools-bash-functions) their own scripts, while keeping those if they remove script-tools, so they wont have to rewrite them.
To your ending saying, it (should?) creates a script script-tools.sh in /etc/profile.d which will be read on start and modifying PATH, so it can be ran from any terminal.
TODO:
* Add code to remove $stDir/script/${/home/users}
* Fix naming
The reference to your homedir is in the package I build; there's nothing dynamic about it. The magic you do with /etc/profile.d is... not really acceptable. For one, it doesn't work with csh/tcsh. For another, it's a pretty rare occurrence for any package to need to modify the path. I'm really not understanding what is so special about this package. If this is just a collection of scripts, package them properly into /usr/bin. Why does it need dynamic references to the your home directory and such? The fixed-symlink, is the result of the checking if there is a $HOME/bin/$USER* directory, if there is one, it creates the symlink, which was left over while i did the fist packaging. Until now, i didnt feel comfortable with placing them into /usr/bin as the scripts require a directory structure, which i didnt thought would be allowed/welcomed to be created in /usr/bin. To see what i mean, please have a look at: http://sea.hostingsociety.com/?p=Script-Tools&stc=Structure --> Thats why i thought /usr/bin was no option for my scripts. <<-- The /etc/profile.d/ way was either a suggestion in on of the earlier review requests or in a forum thread. In the homedirectory, the configuration files are stored. That is, if you re-install Fedora onto your computer, keeping the current /home partition, you wont have to 'run/search' for all values again, so there is no need to re-setup it (for examples the "dev" or "net nas" section). Forgot to add, the current scripts doesnt work properly on the call: "st dev release". As soon the release script works, i'll update the upstream and post it here again with the fixed spec (naming!) and the changelog. Spec: http://sourceforge.net/projects/script-tools/files/script-tools.spec/download Source: http://sourceforge.net/projects/script-tools/files/srpm/script-tools-0.6.5-1.alpha.fc17.src.rpm/download Created attachment 785633 [details]
Tarball
Created attachment 785634 [details]
Specfile
Created attachment 785636 [details]
Package 'source'
Spec: http://sourceforge.net/projects/script-tools/files/script-tools.spec/download Source: http://sourceforge.net/projects/script-tools/files/script-tools-0.8.2-beta.fc19.src.rpm/download Repo: http://sourceforge.net/projects/script-tools/files/script-tools.repo/download Tarball: http://sourceforge.net/projects/script-tools/files/script-tools-0.8.2.tar.gz/download Koji 1: http://koji.fedoraproject.org/koji/taskinfo?taskID=5796920 Koji 2: http://koji.fedoraproject.org/koji/taskinfo?taskID=5796912 -------------------------------------------------------------------------- For either explaining, shocking or amusement purposes a video, done early morning after working the night through, to present how one may 'release' package using script-tools (st dev release LABEL) or how i have configured it once, to keep everything working for me with just 1 line in shell. http://www.youtube.com/watch?v=CIeDLZgHpBM *** This bug has been marked as a duplicate of bug 996530 *** |