Hoi Rex
Invalid Source0:   ftp://ftp.kde.org/pub/kde/stable/4.8.90/src/kde-base-artwork-4.8.90.tar.xz... 
Probably its a tar.gz or reviewer needs special permission to access source location?

First time doing a review, experienced Reviewer: please review the rebiew.

URL typo, *should* have "unstable" instead of "stable" in there.

First time doing a review, experienced Reviewer: please review the rebiew.

rpmlint kde-base-artwork-4.8.90-1.fc17.src.rpm 
kde-base-artwork.src: I: enchant-dictionary-not-found en_US
kde-base-artwork.src: W: invalid-url Source0: ftp://ftp.kde.org/pub/kde/stable/4.8.90/src/kde-base-artwork-4.8.90.tar.xz <urlopen error ftp error: 550 Failed to change directory.>
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

--> Accessing its ftp directory, an error 601 appears... <--


Review Rapport:
+ Naming
+ Specfile
+ Spec is US-English
- Source0
+ Lisence accepted
+ COPYING shipped
+ Lisence is in %doc
- Review file does not match upstream, due to previous errors,
  please see:  https://fedoraproject.org/wiki/Packaging/SourceURL
? Build could not be tested: Invalid Source0
? No system lib files found: Invalid Source0
+ Package is not relocatable
+ Own its directories
+ No double entries in %files
+ No executable files to set permission
? Could not check for forbidden .la libtool archives: Invalid Source0
- Missing Desktop Icon, or comment why none available
+ Proper filesystem ownership
? Could not verify packaged files: Invalid Source0

Hope this is an acceptable review

Ok, please fix it and re-upload specfile and source package.

rpm2cpio  kde-base-artwork-4.8.90-1.fc17.src.rpm | cpio -idmv


Review Update & Additions:
--------------------------
? Could not check for forbidden .la libtool archives: Invalid Source0
+ No forbidden .la libtool found

? Could not verify packaged files: Invalid Source0
+ All files using UTF-8 naming

? No system lib files found: Invalid Source0
+ No lib files shipped

- Missing Desktop Icon, or comment why none available
+ Since its a splashscreen, no icon required.


Remaining Blockers:
-------------------
- Source0
- Build fails (See below)


------------------------
yum list installed cmake
Installierte Pakete
cmake.i686           2.8.8-4.fc17                       @updates
----

CMake Error: CMake was unable to find a build program corresponding to "Unix Makefiles".  CMAKE_MAKE_PROGRAM is not set.  You probably need to select a different build tool.
CMake Error: Error required internal CMake variable not set, cmake may be not be built correctly.
Missing variable is:
CMAKE_C_COMPILER_ENV_VAR
CMake Error: Error required internal CMake variable not set, cmake may be not be built correctly.
Missing variable is:
CMAKE_C_COMPILER
CMake Error: Could not find cmake module file:/home/simon/rpmbuild/BUILD/kde-base-artwork-4.8.90/noarch-redhat-linux-gnu/CMakeFiles/CMakeCCompiler.cmake
CMake Error: Error required internal CMake variable not set, cmake may be not be built correctly.
Missing variable is:
CMAKE_CXX_COMPILER_ENV_VAR
CMake Error: Error required internal CMake variable not set, cmake may be not be built correctly.
Missing variable is:
CMAKE_CXX_COMPILER
CMake Error: Could not find cmake module file:/home/simon/rpmbuild/BUILD/kde-base-artwork-4.8.90/noarch-redhat-linux-gnu/CMakeFiles/CMakeCXXCompiler.cmake
CMake Error: CMAKE_C_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
CMake Warning (dev) in CMakeLists.txt:
  No cmake_minimum_required command is present.  A line of code such as

    cmake_minimum_required(VERSION 2.8)

  should be added at the top of the file.  The version specified may be lower
  if you wish to support older CMake versions for this project.  For more
  information run "cmake --help-policy CMP0000".
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Configuring incomplete, errors occurred!
Fehler: Fehler-Status beim Beenden von /var/tmp/rpm-tmp.9szNnH (%build)


Fehler beim Bauen des RPM:
    Benutzer rdieter1 existiert nicht - benutze Root
    Gruppe rdieter1 existiert nicht - benutze Root
    Benutzer rdieter1 existiert nicht - benutze Root
    Gruppe rdieter1 existiert nicht - benutze Root
    Fehler-Status beim Beenden von /var/tmp/rpm-tmp.9szNnH (%build)

Your build failure here is due to lack of a default build environment, try
yum groupinstall buildsys-build
first

Spec URL: http://rdieter.fedorapeople.org/rpms/kde-base-artwork/kde-base-artwork.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kde-base-artwork/kde-base-artwork-4.8.95-1.fc17.src.rpm

%changelog
* Fri Jun 29 2012 Rex Dieter <rdieter> 4.8.95-1
- 4.8.95
- fix URL

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=4207477

Another try
http://koji.fedoraproject.org/koji/taskinfo?taskID=4207494

Review Update:
--------------
- Source0
+ Source0 fixed

- Build fails (See below)
+ Build succeeds

Review passed, no more blockers.

ACCEPT

But cant set fedora-review flag to: +
Since i'm no proven packager.

> Your build failure here is due to lack of a default build environment, try
> yum groupinstall buildsys-build
> first

Actually, I don't recommend using rpmbuild directly for the test builds at all, but mock or koji scratch-build. (The latter is only accessible to sponsored packagers though.)

> But cant set fedora-review flag to: +
> Since i'm no proven packager.

s/proven/sponsored/

This should:
Requires: kde-workspace
not just kde-filesystem. %{_kde4_appsdir}/ksplash and %{_kde4_appsdir}/ksplash/Themes are owned by kde-workspace, and besides this theme is useless without KSplash installed.

Being a sponsored packager is in no way required in order to do koji scratch builds.

True that @ Jason.
Changed my review script to use koji instead, which saves also the hazzle to localy install the required packages to build.
But imho also takes the ability to verify the installation, which i had forgotton to test.

@ Kevin, so now i wait for the update do a final check?
Or do you want to take over?

Simon, thanks for the review, imo, and is adequate, would you mind setting review flag to + if you APPROVE then?

Rex, sorry due to moving apartments i forgot about it.
Still cant approve, so i reset it, and hope Kevin (since he'd postet here) or someone else can do set the approval flag for you.

Which was the reason for my last post here, obviously.

Either way, please do the changes Kevin asked to in Comment 13 : https://bugzilla.redhat.com/show_bug.cgi?id=835099#c13

Once that is applied i (unexperienced) see no reason to not approve it. (german syntax)

Spec URL: http://rdieter.fedorapeople.org/rpms/kde-base-artwork/kde-base-artwork.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kde-base-artwork/kde-base-artwork-4.9.0-1.fc17.src.rpm

%changelog
* Fri Jul 27 2012 Rex Dieter <rdieter> 4.9.0-1
- 4.9.0
- Requires: kde-workspace

This is fine now, all the issues raised were addressed.

APPROVED

thanks.

New Package SCM Request
=======================
Package Name: kde-base-artwork
Short Description: KDE Base Artwork
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f17

Git done (by process-git-requests).

imported