Bug 839815

Summary: RFE: [PATCH] Add Miscellanea::RequireRcsKeywords, dropped from Perl-Critic
Product: [Fedora] Fedora Reporter: Paul Howarth <paul>
Component: perl-Perl-Critic-MoreAssignee: Petr Pisar <ppisar>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: mmaslano, perl-devel, ppisar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: perl-Perl-Critic-More-1.000-6.fc18 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-13 09:05:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Add Miscellanea::RequireRcsKeywords policy none

Description Paul Howarth 2012-07-12 23:10:19 UTC
Created attachment 597914 [details]
Add Miscellanea::RequireRcsKeywords policy

The Miscellanea::RequireRcsKeywords policy has been dropped from the core Perl-Critic distribution in version 1.118 and is on its way to joining Perl-Critic-More (see CPAN RT#69546). Since Perl-Critic 1.118 is now in Rawhide, that policy is currently unavailable in Rawhide. We could wait until Perl-Critic-More is updated but apparently upstream wants to do quite a bit of work on it before releasing an update.

In the meantime, it would be good to bundle the policy with the current release of Perl-Critic-More. The attached patch adds the policy and fixes up the test suite to expect its presence.

Comment 1 Petr Pisar 2012-07-13 08:33:49 UTC
That sounds reasonable. I will add it.

Comment 2 Petr Pisar 2013-10-29 10:21:32 UTC
The policy has been moved to Perl-Critic-Deprecated distribution at the end <http://cpansearch.perl.org/src/THALJEF/Perl-Critic-Deprecated-1.118/Changes>.

I will remove the patch from perl-Perl-Critic-More package and upgrade Perl-Critic-Deprecated (bug #1023708).