Bug 841112

Summary: __pmDecodeIDList lacks check against PDU size
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: pcpAssignee: Nathan Scott <nathans>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: kenj, mgoodwin, nathans, security-response-team
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcp-3.6.5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-20 03:52:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 840765, 841698    
Attachments:
Description Flags
Resolve issues in decoding PCP namespace idlist PDUs none

Description Florian Weimer 2012-07-18 08:10:46 UTC 
__pmDecodeIDList does not check that the incoming PDU actually contains room for numids elements.  This looks like it could result in a client crash (read buffer overflow, not exploitable for code execution) when a server sends too few IDs.
Comment 1 Mark Goodwin 2012-07-22 23:44:09 UTC 
Nathan requested assignment, thanks Nathan
Comment 2 Nathan Scott 2012-07-27 06:27:26 UTC 
Created attachment 600699 [details]
Resolve issues in decoding PCP namespace idlist PDUs
Comment 3 Florian Weimer 2012-07-27 13:22:53 UTC 
(In reply to comment #2)
> Created attachment 600699 [details]
> Resolve issues in decoding PCP namespace idlist PDUs

Looks good to me.
Comment 4 Huzaifa S. Sidhpurwala 2012-08-16 03:45:53 UTC 
Upstream patch:

http://oss.sgi.com/cgi-bin/gitweb.cgi?p=pcp/pcp.git;a=commit;h=b441980d53be1835b25f0cd6bcc0062da82032dd

This issue has been addressed in pcp-3.6.5
Comment 5 Huzaifa S. Sidhpurwala 2012-08-20 03:52:42 UTC 
This issue was addressed in Fedora and EPEL via the following security updates:

Fedora-16: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.fc16
Fedora-17: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.fc17
Rawhide:   https://admin.fedoraproject.org/updates/pcp-3.6.5-1.fc18

EPEL-5: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.el5
EPEL-6: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.el6