Bug 841112 – __pmDecodeIDList lacks check against PDU size

Bug 841112 - __pmDecodeIDList lacks check against PDU size

Summary:	__pmDecodeIDList lacks check against PDU size

Status:	CLOSED ERRATA

Aliases:	None

Product:	Fedora
Classification:	Fedora
Component:	pcp (Show other bugs)
Sub Component:
Version:	16
Hardware:	Unspecified Unspecified

Priority	unspecified Severity unspecified
Target Milestone:	---
Target Release:	---
Assigned To:	Nathan Scott
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:

URL:
Whiteboard:
Keywords:	Security

Depends On:
Blocks:	840765 CVE-2012-3418
	Show dependency tree / graph

Reported:	2012-07-18 04:10 EDT by Florian Weimer
Modified:	2012-08-19 23:52 EDT (History)
CC List:	4 users (show)

See Also:
Fixed In Version:	pcp-3.6.5
Doc Type:	Bug Fix
Doc Text:
Story Points:	---
Clone Of:
Environment:
Last Closed:	2012-08-19 23:52:42 EDT
Type:	Bug
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Category:	---
oVirt Team:	---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Attachments	(Terms of Use)
Resolve issues in decoding PCP namespace idlist PDUs (1.14 KB, patch) 2012-07-27 02:27 EDT, Nathan Scott	no flags	Details \| Diff
Add an attachment (proposed patch, testcase, etc.)

Groups: None (edit)

Description Florian Weimer 2012-07-18 04:10:46 EDT

__pmDecodeIDList does not check that the incoming PDU actually contains room for numids elements.  This looks like it could result in a client crash (read buffer overflow, not exploitable for code execution) when a server sends too few IDs.

Comment 1 Mark Goodwin 2012-07-22 19:44:09 EDT

Nathan requested assignment, thanks Nathan

Comment 2 Nathan Scott 2012-07-27 02:27:26 EDT

Created attachment 600699 [details]
Resolve issues in decoding PCP namespace idlist PDUs

Comment 3 Florian Weimer 2012-07-27 09:22:53 EDT

(In reply to comment #2)
> Created attachment 600699 [details]
> Resolve issues in decoding PCP namespace idlist PDUs

Looks good to me.

Comment 4 Huzaifa S. Sidhpurwala 2012-08-15 23:45:53 EDT

Upstream patch:

http://oss.sgi.com/cgi-bin/gitweb.cgi?p=pcp/pcp.git;a=commit;h=b441980d53be1835b25f0cd6bcc0062da82032dd

This issue has been addressed in pcp-3.6.5

Comment 5 Huzaifa S. Sidhpurwala 2012-08-19 23:52:42 EDT

This issue was addressed in Fedora and EPEL via the following security updates:

Fedora-16: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.fc16
Fedora-17: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.fc17
Rawhide:   https://admin.fedoraproject.org/updates/pcp-3.6.5-1.fc18

EPEL-5: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.el5
EPEL-6: https://admin.fedoraproject.org/updates/pcp-3.6.5-1.el6

Note You need to log in before you can comment on or make changes to this bug.