Bug 841641

Summary: Review Request: rubygem-gearchanger-mcollective-plugin - GearChanger plugin for mcollective service
Product: [Fedora] Fedora Reporter: Adam Miller <maxamillion>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: admiller, notting, package-review, tdawson
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-01 15:15:03 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On: 839064    
Bug Blocks:    

Description Adam Miller 2012-07-19 13:24:08 EDT
Spec URL: http://maxamillion.fedorapeople.org/gearchanger-mcollective-plugin.spec
SRPM URL: http://maxamillion.fedorapeople.org/rubygem-gearchanger-mcollective-plugin-0.1.1-1.el6.src.rpm
Description: GearChanger plugin for mcollective based node/gear manager
Fedora Account System Username: maxamillion
Comment 1 Troy Dawson 2012-07-24 18:13:41 EDT
Informal Review:
The spec file needs to match the rpm name.
Please rename gearchanger-mcollective-plugin.spec to rubygems-gearchanger-mcollective-plugin.spec

Although you have these variables defined for older releases, you don't use them when it is time to.  Please use
%{gem_instdir}
%{gem_docdir}
%{gem_cache}
%{gem_spec}

Also, for your definition, you should define gem_spec as 

  %{gem_dir}/specifications/%{gem_name}-%{version}.gemspec

For Source0, use http://mirror.openshift.com/ instead of https://mirror.openshift.com/
Sometimes for the automated testing it doesn't like the https, and the http works just fine.

From rpmlint:
rubygem-gearchanger-mcollective-plugin.noarch: E: script-without-shebang /usr/share/gems/gems/gearchanger-mcollective-plugin-0.1.1/lib/gea
rchanger-mcollective-plugin/gearchanger/mcollective_application_container_proxy.rb

Rpmlint Trivial Things:
mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 76)
Comment 2 Adam Miller 2012-07-24 19:07:32 EDT
I would like to add FAS account name tdawson to this review as I'll be out of town for the next week and don't want to be a blocker.

Fedora Account System Username: maxamillion tdawson
Comment 3 Adam Miller 2012-08-01 15:15:03 EDT

*** This bug has been marked as a duplicate of bug 845107 ***