Spec URL: http://maxamillion.fedorapeople.org/gearchanger-mcollective-plugin.spec SRPM URL: http://maxamillion.fedorapeople.org/rubygem-gearchanger-mcollective-plugin-0.1.1-1.el6.src.rpm Description: GearChanger plugin for mcollective based node/gear manager Fedora Account System Username: maxamillion
Informal Review: The spec file needs to match the rpm name. Please rename gearchanger-mcollective-plugin.spec to rubygems-gearchanger-mcollective-plugin.spec Although you have these variables defined for older releases, you don't use them when it is time to. Please use %{gem_instdir} %{gem_docdir} %{gem_cache} %{gem_spec} Also, for your definition, you should define gem_spec as %{gem_dir}/specifications/%{gem_name}-%{version}.gemspec For Source0, use http://mirror.openshift.com/ instead of https://mirror.openshift.com/ Sometimes for the automated testing it doesn't like the https, and the http works just fine. From rpmlint: rubygem-gearchanger-mcollective-plugin.noarch: E: script-without-shebang /usr/share/gems/gems/gearchanger-mcollective-plugin-0.1.1/lib/gea rchanger-mcollective-plugin/gearchanger/mcollective_application_container_proxy.rb Rpmlint Trivial Things: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 76)
I would like to add FAS account name tdawson to this review as I'll be out of town for the next week and don't want to be a blocker. Fedora Account System Username: maxamillion tdawson
*** This bug has been marked as a duplicate of bug 845107 ***