Bug 842296
| Summary: | Review Request: kde-plasma-akonadi-calendars - Akonadi calendars plasmoid | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Lukáš Tinkl <ltinkl> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jgrulich, kevin, ltinkl, notting, package-review, rdieter |
| Target Milestone: | --- | Flags: | ltinkl:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-13 02:24:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Jan Grulich
2012-07-23 12:08:33 UTC
- BuildRoot and Group tags are redundant - Source should point to the canonical source on the internet - the preferred tarball format is tar.bz2 or even tar.xz New Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm I've sponsored Jan into packager group, largely due to other mentoring tasks by Lukáš and other fellow kde-sig'ers. [ltinkl@goblin 842296]$ rpmlint kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm kde-plasma-akonadi-calendars.src: W: spelling-error Summary(en_US) plasmoid -> plasma kde-plasma-akonadi-calendars.src: W: spelling-error %description -l en_US plasmoid -> plasma kde-plasma-akonadi-calendars.src: W: invalid-url Source0: http://kde-look.org/CONTENT/content-files/150034-10534-akonadi-calendars.tar.bz2 HTTP Error 404: Not Found 1 packages and 0 specfiles checked; 0 errors, 3 warnings. - please provide a working Source URL - the correct URL seems to be: http://kde-look.org/CONTENT/content-files/150034-150034-akonadi-calendars.tar.bz2 - no newline at the end of specfile New: Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm - link and also tarball name fixed - others are not problems License tag from .spec file (GPLv2+) doesn't match the actual source code license (GPLv3+) New: Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm - fix licence tag New: Spec URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SPECS/kde-plasma-akonadi-calendars.spec SRPM URL: http://phoenix.inf.upol.cz/~grulichj/rpmbuild/SRPMS/kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm - add missing newline at the end of specfile Package builds ok, meets all the MUST criteria, license correct too. RPMlint: [ltinkl@goblin 842296]$ rpmlint kde-plasma-akonadi-calendars-0.1.1-1.fc17.src.rpm kde-plasma-akonadi-calendars.src: W: spelling-error Summary(en_US) plasmoid -> plasma kde-plasma-akonadi-calendars.src: W: spelling-error %description -l en_US plasmoid -> plasma 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=4322576 http://koji.fedoraproject.org/koji/taskinfo?taskID=4322839 New Package SCM Request ======================= Package Name: kde-plasma-akonadi-calendars Short Description: Calendars plasmoid for Akonadi resources Owners: jgrulich Branches: f17 InitialCC: jgrulich ltinkl Git done (by process-git-requests). kde-plasma-akonadi-calendars-0.1.1-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/kde-plasma-akonadi-calendars-0.1.1-1.fc17 kde-plasma-akonadi-calendars-0.1.1-1.fc17 has been pushed to the Fedora 17 testing repository. kde-plasma-akonadi-calendars-0.1.1-1.fc17 has been pushed to the Fedora 17 stable repository. |