Bug 843238

Summary: libharu package has not built for multiple Fedora releases
Product: [Fedora] Fedora Reporter: Bill Nottingham <notting>
Component: libharuAssignee: Alex Orlandi <nyrk71>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: nyrk71, rvokal, tcallawa, tgl
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-31 20:40:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 713919    
Attachments:
Description Flags
fix direct accesses to libpng's private png_info struct none

Description Bill Nottingham 2012-07-25 22:10:01 UTC 
This package has not been built since Fedora 15, having failed multiple mass
rebuild cycles.

As part of the normal process for retiring packages that have not
successfully built, this package is scheduled to be removed from Fedora on
or around the Fedora 18 branch date (August 7th).

Please fix this as soon as possible.
Comment 1 Tom Lane 2012-07-28 17:13:22 UTC 
The FTBFS problem is due to libpng no longer allowing direct access to struct png_info.  If there is any interest in reviving this package, I attach a patch to fix that.  I note though that the version we're packaging is obsolete upstream (cf bug #654755), and that the build is full of warnings like
warning: #warning _FORTIFY_SOURCE requires compiling with optimization (-O)
So it needs more attention than just applying this patch.
Comment 2 Tom Lane 2012-07-28 17:14:05 UTC 
Created attachment 600935 [details]
fix direct accesses to libpng's private png_info struct
Comment 3 Tom "spot" Callaway 2012-07-31 20:40:57 UTC 
I fixed this in basically the same way, except I conditionalized it so that the old code would be present and work for older libpngs.

Fixed in 2.2.1-1.fc18.
Comment 4 Tom Lane 2012-08-01 05:43:16 UTC 
FWIW, I doubt that conditionalization is necessary --- we have not shipped libpng 1.0 in a very long time.  But anyway, thanks for fixing.
Comment 5 Tom "spot" Callaway 2012-08-01 13:41:40 UTC 
It's clearly unnecessary for Fedora, but in several previous package fixes, the upstream wouldn't take the patch unless it was conditionalized.