Bug 844621

Summary:	Review Request: perl-Log-Contextual - Simple logging interface with a contextual log
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	notting, package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Log-Contextual-0.004300-1.fc19	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-06 14:44:04 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	844610
Bug Blocks:	844670

Description Jitka Plesnikova 2012-07-31 08:37:02 UTC

Spec URL: http://jplesnik.fedorapeople.org/perl-Log-Contextual/perl-Log-Contextual.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Log-Contextual/perl-Log-Contextual-0.004201-1.fc18.src.rpm
Description:
This module is a simple interface to extensible logging. It is bundled with
a really basic logger, Log::Contextual::SimpleLogger, but in general you
should use a real logger instead of that. For something more serious but
not overly complicated, try Log::Dispatchouli.

Fedora Account System Username: jplesnik

Comment 1 Jitka Plesnikova 2013-01-30 13:43:36 UTC

Spec URL: http://jplesnik.fedorapeople.org/perl-Log-Contextual/perl-Log-Contextual.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Log-Contextual/perl-Log-Contextual-0.004300-1.fc19.src.rpm
Description:
This module is a simple interface to extensible logging. It is bundled with
a really basic logger, Log::Contextual::SimpleLogger, but in general you
should use a real logger instead of that. For something more serious but
not overly complicated, try Log::Dispatchouli.

Fedora Account System Username: jplesnik

Comment 2 Petr Pisar 2013-02-05 14:49:05 UTC

URL and Source0 are usable. Ok.
Source tar ball is original (SHA-256: 68f62f269ffbbb430daa1c78f1459ad733cacda9fed63b0d048c4b5ae2c00cdc). Ok.
Summary verified from META.yml. Ok.
Description verified from lib/Log/Contextual.pm. Ok.
License verified from lib/Log/Contextual.pm. Ok.
No XS code, noarch BuildArch is Ok.

TODO: You can use DESTDIR argument instead of PERL_INSTALL_ROOT in %install section.

Log::Log4perl is optional. Ok.

TODO: Remove useless build-require `perl(ExtUtils::MakeMaker)'. All occurrences are in removed inc/.

FIX: Remove useless build-require `perl(Test::Fatal)'. It's not used anywhere.
FIX: Build-require `perl(Exporter::Declare::Export::Generator)' (lib/Log/Contextual.pm:11).

All tests pass. Ok.

$ rpmlint perl-Log-Contextual.spec ../SRPMS/perl-Log-Contextual-0.004300-1.fc19.src.rpm ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm
perl-Log-Contextual.spec: E: specfile-error warning: bogus date in %changelog: Tue Jul 21 2012 Jitka Plesnikova <jplesnik> - 0.004201-1
perl-Log-Contextual.src: W: spelling-error %description -l en_US SimpleLogger -> Simple Logger, Simple-logger, Oversimple
perl-Log-Contextual.src: W: spelling-error %description -l en_US Dispatchouli -> Dis patchouli, Dis-patchouli, Patchouli
perl-Log-Contextual.src: E: specfile-error warning: bogus date in %changelog: Tue Jul 21 2012 Jitka Plesnikova <jplesnik> - 0.004201-1
perl-Log-Contextual.noarch: W: spelling-error %description -l en_US SimpleLogger -> Simple Logger, Simple-logger, Oversimple
perl-Log-Contextual.noarch: W: spelling-error %description -l en_US Dispatchouli -> Dis patchouli, Dis-patchouli, Patchouli
2 packages and 1 specfiles checked; 2 errors, 4 warnings.

FIX: Use valid date in changelog entry.

$ rpm -q -l -v -p ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm 
drwxr-xr-x    2 root    root                        0 Feb  5 15:27 /usr/share/doc/perl-Log-Contextual-0.004300
-rw-r--r--    1 root    root                     1763 Oct  4 00:18 /usr/share/doc/perl-Log-Contextual-0.004300/Changes
-rw-r--r--    1 root    root                     7061 Feb  5 15:27 /usr/share/man/man3/Log::Contextual.3pm.gz
-rw-r--r--    1 root    root                     3020 Feb  5 15:27 /usr/share/man/man3/Log::Contextual::SimpleLogger.3pm.gz
-rw-r--r--    1 root    root                     3017 Feb  5 15:27 /usr/share/man/man3/Log::Contextual::TeeLogger.3pm.gz
-rw-r--r--    1 root    root                     3447 Feb  5 15:27 /usr/share/man/man3/Log::Contextual::WarnLogger.3pm.gz
drwxr-xr-x    2 root    root                        0 Feb  5 15:27 /usr/share/perl5/vendor_perl/Log
drwxr-xr-x    2 root    root                        0 Feb  5 15:27 /usr/share/perl5/vendor_perl/Log/Contextual
-rw-r--r--    1 root    root                    18150 Oct  4 00:17 /usr/share/perl5/vendor_perl/Log/Contextual.pm
-rw-r--r--    1 root    root                     3587 Aug  9  2012 /usr/share/perl5/vendor_perl/Log/Contextual/SimpleLogger.pm
-rw-r--r--    1 root    root                     3210 Aug  9  2012 /usr/share/perl5/vendor_perl/Log/Contextual/TeeLogger.pm
-rw-r--r--    1 root    root                     6041 Aug  9  2012 /usr/share/perl5/vendor_perl/Log/Contextual/WarnLogger.pm
File layout and permissions are Ok.

$ rpm -q -l --requires -p ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(Data::Dumper::Concise)
      1 perl(Exporter::Declare)
      1 perl(Exporter::Declare) >= 0.105
      1 perl(Exporter::Declare::Export::Generator)
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
      1 /usr/share/doc/perl-Log-Contextual-0.004300
      1 /usr/share/doc/perl-Log-Contextual-0.004300/Changes
      1 /usr/share/man/man3/Log::Contextual.3pm.gz
      1 /usr/share/man/man3/Log::Contextual::SimpleLogger.3pm.gz
      1 /usr/share/man/man3/Log::Contextual::TeeLogger.3pm.gz
      1 /usr/share/man/man3/Log::Contextual::WarnLogger.3pm.gz
      1 /usr/share/perl5/vendor_perl/Log
      1 /usr/share/perl5/vendor_perl/Log/Contextual
      1 /usr/share/perl5/vendor_perl/Log/Contextual.pm
      1 /usr/share/perl5/vendor_perl/Log/Contextual/SimpleLogger.pm
      1 /usr/share/perl5/vendor_perl/Log/Contextual/TeeLogger.pm
      1 /usr/share/perl5/vendor_perl/Log/Contextual/WarnLogger.pm

TODO: Do not require unversioned `perl(Exporter::Declare)'.

$ rpm -q -l --provides -p ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Log::Contextual) = 0.004300
      1 perl-Log-Contextual = 0.004300-1.fc19
      1 perl(Log::Contextual::SimpleLogger)
      1 perl(Log::Contextual::TeeLogger)
      1 perl(Log::Contextual::WarnLogger)
      1 /usr/share/doc/perl-Log-Contextual-0.004300
      1 /usr/share/doc/perl-Log-Contextual-0.004300/Changes
      1 /usr/share/man/man3/Log::Contextual.3pm.gz
      1 /usr/share/man/man3/Log::Contextual::SimpleLogger.3pm.gz
      1 /usr/share/man/man3/Log::Contextual::TeeLogger.3pm.gz
      1 /usr/share/man/man3/Log::Contextual::WarnLogger.3pm.gz
      1 /usr/share/perl5/vendor_perl/Log
      1 /usr/share/perl5/vendor_perl/Log/Contextual
      1 /usr/share/perl5/vendor_perl/Log/Contextual.pm
      1 /usr/share/perl5/vendor_perl/Log/Contextual/SimpleLogger.pm
      1 /usr/share/perl5/vendor_perl/Log/Contextual/TeeLogger.pm
      1 /usr/share/perl5/vendor_perl/Log/Contextual/WarnLogger.pm
Binary provides are Ok.

$ resolvedeps rawhide  ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4930081). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.


Please correct all `FIX' issues, consider fixing `TODO' items, and provide new spec file.
Resolution: Package NOT approved.

Comment 3 Jitka Plesnikova 2013-02-05 16:44:39 UTC

Spec was updated.

Spec URL: http://jplesnik.fedorapeople.org/perl-Log-Contextual/perl-Log-Contextual.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Log-Contextual/perl-Log-Contextual-0.004300-1.fc19.src.rpm

Comment 4 Petr Pisar 2013-02-06 08:31:34 UTC

Spec file changes:
--- perl-Log-Contextual.spec.old        2013-01-30 14:40:54.000000000 +0100
+++ perl-Log-Contextual.spec    2013-02-05 17:39:45.000000000 +0100
@@ -12,16 +12,18 @@
 BuildRequires:  perl(Carp)
 BuildRequires:  perl(Data::Dumper::Concise)
 BuildRequires:  perl(Exporter::Declare) >= 0.105
-BuildRequires:  perl(ExtUtils::MakeMaker)
+BuildRequires:  perl(Exporter::Declare::Export::Generator)
 BuildRequires:  perl(File::Temp)
 BuildRequires:  perl(lib)
 BuildRequires:  perl(Log::Log4perl) >= 1.29
 BuildRequires:  perl(Scalar::Util)
-BuildRequires:  perl(Test::Fatal)
 BuildRequires:  perl(Test::More)
 Requires:       perl(Exporter::Declare) >= 0.105
 Requires:       perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version))

+# Filter under-specified depenedencies
+%global __requires_exclude %{?__provides_exclude:%__provides_exclude|}^perl\\(Exporter::Declare\\)\\s*$
+
 %description
 This module is a simple interface to extensible logging. It is bundled with
 a really basic logger, Log::Contextual::SimpleLogger, but in general you
@@ -39,7 +41,7 @@
 make %{?_smp_mflags}

 %install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
 find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
 %{_fixperms} $RPM_BUILD_ROOT/*

@@ -54,6 +56,8 @@
 %changelog
 * Wed Jan 30 2013 Jitka Plesnikova <jplesnik> - 0.004300-1
 - 0.004300 bump
+- Update BRs.
+- Replace PERL_INSTALL_ROOT with DESTDIR.

-* Tue Jul 21 2012 Jitka Plesnikova <jplesnik> - 0.004201-1
+* Tue Jul 24 2012 Jitka Plesnikova <jplesnik> - 0.004201-1
 - Specfile autogenerated by cpanspec 1.78.


> TODO: You can use DESTDIR argument instead of PERL_INSTALL_ROOT in %install section.
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=$RPM_BUILD_ROOT
Ok.

> TODO: Remove useless build-require `perl(ExtUtils::MakeMaker)'. All occurrences are in removed inc/.
-BuildRequires:  perl(ExtUtils::MakeMaker)
Ok.

> FIX: Remove useless build-require `perl(Test::Fatal)'. It's not used anywhere.
-BuildRequires:  perl(Test::Fatal)
Ok.

> FIX: Build-require `perl(Exporter::Declare::Export::Generator)' (lib/Log/Contextual.pm:11).
+BuildRequires:  perl(Exporter::Declare::Export::Generator)
Ok.

> FIX: Use valid date in changelog entry.
-* Tue Jul 21 2012 Jitka Plesnikova <jplesnik> - 0.004201-1
+* Tue Jul 24 2012 Jitka Plesnikova <jplesnik> - 0.004201-1
Ok.

$ rpmlint perl-Log-Contextual.spec ../SRPMS/perl-Log-Contextual-0.004300-1.fc19.src.rpm ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm
perl-Log-Contextual.src: W: spelling-error %description -l en_US SimpleLogger -> Simple Logger, Simple-logger, Oversimple
perl-Log-Contextual.src: W: spelling-error %description -l en_US Dispatchouli -> Dis patchouli, Dis-patchouli, Patchouli
perl-Log-Contextual.noarch: W: spelling-error %description -l en_US SimpleLogger -> Simple Logger, Simple-logger, Oversimple
perl-Log-Contextual.noarch: W: spelling-error %description -l en_US Dispatchouli -> Dis patchouli, Dis-patchouli, Patchouli
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
rpmlint is Ok.


> TODO: Do not require unversioned `perl(Exporter::Declare)'.
$ rpm -q --requires -p ../RPMS/noarch/perl-Log-Contextual-0.004300-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(Data::Dumper::Concise)
      1 perl(Exporter::Declare) >= 0.105
      1 perl(Exporter::Declare::Export::Generator)
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4932144). Ok.

Package is good.
Resolution: Package APPROVED.

Comment 5 Jitka Plesnikova 2013-02-06 08:38:23 UTC

New Package SCM Request
=======================
Package Name: perl-Log-Contextual
Short Description: Simple logging interface with a contextual log
Owners: jplesnik ppisar psabata
Branches:
InitialCC: perl-sig

Comment 6 Gwyn Ciesla 2013-02-06 13:33:06 UTC

Git done (by process-git-requests).

Comment 7 Jitka Plesnikova 2013-02-06 14:44:04 UTC

Thank you for the review and the repository.

Comment 8 Gwyn Ciesla 2013-02-06 14:55:17 UTC

Unsetting cvs flag.