Bug 844670 - Review Request: perl-Task-Kensho-Logging - A Glimpse at an Enlightened Perl (Logging)
Summary: Review Request: perl-Task-Kensho-Logging - A Glimpse at an Enlightened Perl (...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 844621
Blocks:
TreeView+ depends on / blocked
 
Reported: 2012-07-31 10:41 UTC by Jitka Plesnikova
Modified: 2013-03-06 15:13 UTC (History)
3 users (show)

Fixed In Version: perl-Task-Kensho-Logging-0.01-1.fc19
Clone Of:
Environment:
Last Closed: 2013-03-06 15:13:39 UTC
Type: Bug
Embargoed:
ppisar: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Jitka Plesnikova 2012-07-31 10:41:58 UTC
Spec URL: http://jplesnik.fedorapeople.org/perl-Task-Kensho-Logging/perl-Task-Kensho-Logging.spec
SRPM URL: http://jplesnik.fedorapeople.org/perl-Task-Kensho-Logging/perl-Task-Kensho-Logging-0.01-1.fc18.src.rpm
Description:
Task::Kensho is a first cut at building a list of recommended modules for
Enlightened Perl development. This Task installs logging modules.

Fedora Account System Username: jplesnik

Comment 2 Petr Pisar 2013-03-06 14:09:34 UTC
URL and Source0 are usable. Ok.
Source file is original (SHA-256: 053ccb50f2a6479aaffb040fde329746a7dbfa65e5784b20603bc8d9dad13639). Ok.
Summary verified from lib/Task/Kensho/Logging.pm. Ok.
Description is Ok.
License verified from lib/Task/Kensho/Logging.pm. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Task-Kensho-Logging.spec ../SRPMS/perl-Task-Kensho-Logging-0.01-1.fc19.src.rpm ../RPMS/noarch/perl-Task-Kensho-Logging-0.01-1.fc19.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Task-Kensho-Logging-0.01-1.fc19.noarch.rpm                                                            drwxr-xr-x    2 root    root                        0 Mar  6 15:01 /usr/share/doc/perl-Task-Kensho-Logging-0.01
-rw-r--r--    1 root    root                       94 Apr 11  2011 /usr/share/doc/perl-Task-Kensho-Logging-0.01/Changes
-rw-r--r--    1 root    root                     1485 Apr 11  2011 /usr/share/doc/perl-Task-Kensho-Logging-0.01/README
-rw-r--r--    1 root    root                     3530 Mar  6 15:00 /usr/share/man/man3/Task::Kensho::Logging.3pm.gz
drwxr-xr-x    2 root    root                        0 Mar  6 15:00 /usr/share/perl5/vendor_perl/Task
drwxr-xr-x    2 root    root                        0 Mar  6 15:00 /usr/share/perl5/vendor_perl/Task/Kensho
-rw-r--r--    1 root    root                     3515 Apr 11  2011 /usr/share/perl5/vendor_perl/Task/Kensho/Logging.pm
File permissions and layout are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Task-Kensho-Logging-0.01-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Log::Contextual)
      1 perl(Log::Dispatch)
      1 perl(Log::Log4perl)
      1 perl(:MODULE_COMPAT_5.16.2)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Task-Kensho-Logging-0.01-1.fc19.noarch.rpm | sort | uniq -c
      1 perl(Task::Kensho::Logging) = 0.01
      1 perl-Task-Kensho-Logging = 0.01-1.fc19
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Task-Kensho-Logging-0.01-1.fc19.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=5084591). Ok.

Package is in line with Fedora and Perl packaging guidelines.
Resolution: Package APPROVED.

Comment 3 Jitka Plesnikova 2013-03-06 14:19:20 UTC
New Package SCM Request
=======================
Package Name: perl-Task-Kensho-Logging
Short Description: A Glimpse at an Enlightened Perl (Logging)
Owners: jplesnik ppisar psabata
Branches:
InitialCC: perl-sig

Comment 4 Gwyn Ciesla 2013-03-06 14:23:38 UTC
Git done (by process-git-requests).

Comment 5 Jitka Plesnikova 2013-03-06 15:13:39 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.