Bug 844761

Summary:	Samba hook script adds redundant sections in smb.conf
Product:	[Community] GlusterFS	Reporter:	Vijay Bellur <vbellur>
Component:	glusterd	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	amarts, gluster-bugs, rtalur
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.4.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	852140 (view as bug list)		Environment:
Last Closed:	2013-07-24 17:27:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	852140, 994727

Description Vijay Bellur 2012-07-31 16:48:16 UTC

Description of problem:

When S30samba-start.sh is used for exporting CIFS through samba and multiple volume start [force] commands are executed, smb.conf would contain multiple redundant sections in smb.conf like:

comment=For samba export of volume object
path=/mnt/samba/object
read only=no
guest ok=yes

[gluster-object]
comment=For samba export of volume object
path=/mnt/samba/object
read only=no
guest ok=yes

[gluster-object]
comment=For samba export of volume object
path=/mnt/samba/object
read only=no
guest ok=yes

[gluster-object]
comment=For samba export of volume object
path=/mnt/samba/object
read only=no
guest ok=yes

This needs to be fixed.

Version-Release number of selected component (if applicable):
3.3.0

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Amar Tumballi 2012-10-18 10:22:12 UTC

Samba hooks are not part of any glusterfs codebase, right??

Comment 2 Vijay Bellur 2012-10-18 10:25:39 UTC

(In reply to comment #1)
> Samba hooks are not part of any glusterfs codebase, right??

Present in extras/hook-scripts.

Comment 3 Raghavendra Talur 2013-07-19 05:40:14 UTC

This is fixed in the current release with the set of changes which have gone into hook scripts.