Bug 844766

Summary: scl not built with $RPM_OPT_FLAGS, $RPM_LD_FLAGS
Product: [Fedora] Fedora Reporter: Ville Skyttä <ville.skytta>
Component: scl-utilsAssignee: Jindrich Novy <jnovy>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: bkabrda, jnovy, pknirsch
Target Milestone: ---Keywords: Patch, Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-02 05:00:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 496968    
Attachments:
Description Flags
Fix dependencies in Makefile none

Description Ville Skyttä 2012-07-31 17:32:56 UTC 
Created attachment 601553 [details]
Fix dependencies in Makefile

scl in 20120731-1 is not built with $RPM_OPT_FLAGS:

http://kojipkgs.fedoraproject.org/packages/scl-utils/20120731/1.fc18/data/logs/x86_64/build.log

Well, actually it is, but then "make install" builds it again without them due to broken deps in Makefile. Fix attached.


Another suggested fix that takes care of using $RPM_LD_FLAGS and parallel build:

--- a/scl-utils.spec
+++ b/scl-utils.spec
@@ -26,4 +26,3 @@ Essential RPM build macros for alternative packaging.
 %build
-export CFLAGS="$RPM_OPT_FLAGS"
-make
+make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_LD_FLAGS"
Comment 1 Jindrich Novy 2012-08-02 04:59:49 UTC 
Applied & fixed in rawhide. Thanks!