Bug 845031
| Summary: | Review Request: gnome-boxes-nonfree - This package provides the non-free content for gnome-boxes package | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Zeeshan Ali <zeenix> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cfergeau, mclasen, notting, package-review, tcallawa |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-31 16:12:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Zeeshan Ali
2012-08-01 14:38:18 UTC
Sorry, wrong SRPM URL. Here is the correct one: http://zeenix.fedorapeople.org/gnome-boxes-nonfree-0.0.2-1.fc17.src.rpm You'll note that I've put 'LGPLv2+' as the Licence but thats not true. Looking at this page, I don't see which would be the right value here though so please let me know which value is appropriate and I'll use that: https://fedoraproject.org/wiki/Licensing#Content_Licenses Also please note that these logos were previously shipped with gnome-boxes package itself and we have been in communication with Fedora legal about this issue: http://lists.fedoraproject.org/pipermail/advisory-board/2012-February/011360.html Please use: License: Licensed only for approved usage, see COPYING for details. (In reply to comment #2) > Please use: > > License: Licensed only for approved usage, see COPYING for details. Thanks! I updated the files: http://zeenix.fedorapeople.org/gnome-boxes-nonfree.spec http://zeenix.fedorapeople.org/gnome-boxes-nonfree-0.0.2-1.fc17.src.rpm 16:28 <@teuf> zeenix: shouldn't this be a noarch package ?
16:28 <@teuf> there is nothing architecture specific in there, is there?
16:29 <@zeenix> nope
16:29 * zeenix updates
16:30 <@teuf> Unlike rest ... -> Unlike the rest ... ?
16:30 <@teuf> pacakge
16:31 <@teuf> existence
16:32 <@teuf> update-desktop-database &> /dev/null || :
16:32 <@teuf> update-mime-database %{_datadir}/mime &> /dev/null || :
16:32 <@teuf> is that installing mime/desktop files ?
16:33 <@teuf> I'd put http://lists.fedoraproject.org/pipermail/advisory-board/2012-February/011360.html in the .spec
"This package contains the nonfree data for Boxes" -> non-free
to ship them in ...
For more details on the rationale for the existence of this package:
you can remove the empty %post sections
I'm not sure about the Requires: gnome-boxes
(In reply to comment #4) > > "This package contains the nonfree data for Boxes" -> non-free > to ship them in ... > For more details on the rationale for the existence of this package: Sorry, didn't catch this bit. > I'm not sure about the Requires: gnome-boxes Just another step to try to ensure that these logos are not used outside Boxes. Updated the the spec/srpm files at the same location according to latest review. Not needed anymore. For details: https://bugzilla.gnome.org/show_bug.cgi?id=682573 |