Bug 845506

Summary: gluster volume start --xml outputs wrong xml structure
Product: [Community] GlusterFS Reporter: Bala.FA <barumuga>
Component: cliAssignee: Kaushal <kaushal>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: high    
Version: mainlineCC: dpati, gluster-bugs
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 849294 (view as bug list) Environment:
Last Closed: 2013-07-24 17:20:58 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 849294, 858461    

Description Bala.FA 2012-08-03 09:24:15 UTC
gluster volume start --xml outputs

<cliOutput>
  <volStart>
    <flags>0</flags>
    <volname>test1</volname>
  </volStart>
</cliOutput>

expected output is
<cliOutput>
  <opRet>0</opRet>
  <opErrno>0</opErrno>
  <opErrstr/>
  <volStart>
    <volume>
      <name>music</name>
      <id>b3114c71-741b-4c6f-a39e-80384c4ea3cf</id>
      <status>1</status>
    </volume>
  </volStart>
</cliOutput>

Comment 1 Kaushal 2012-10-10 07:21:01 UTC
Patch under review at http://review.gluster.org/3869

Comment 2 Kaushal 2012-10-12 03:50:10 UTC
Fixed by commit f1f3d1c (cli: Changes and enhancements to XML output) for bug https://bugzilla.redhat.com/show_bug.cgi?id=828131 . Reviewed at http://review.gluster.org/3869 .

Comment 3 Bala.FA 2012-10-17 06:08:37 UTC
Not fixed in upstream

[root@localhost x86_64]# gluster volume start music --xml
[root@localhost x86_64]# 

If a volume is in started state, it returns error xml correctly

[root@localhost x86_64]# gluster volume start music --xml
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<cliOutput><opRet>-1</opRet><opErrno>0</opErrno><opErrstr>Volume music already started</opErrstr></cliOutput>