Bug 846771

Summary: ovirt-engine-backend [TEXT]: please fix CanDoAction when extend domain fails
Product: Red Hat Enterprise Virtualization Manager Reporter: Dafna Ron <dron>
Component: ovirt-engineAssignee: Laszlo Hornyak <lhornyak>
Status: CLOSED CURRENTRELEASE QA Contact: Dafna Ron <dron>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.1.0CC: abaron, amureini, derez, dfediuck, dyasny, hateya, iheim, lpeer, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---Keywords: EasyFix
Target Release: 3.1.0   
Hardware: x86_64   
OS: Linux   
Whiteboard: storage
Fixed In Version: SI24 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
logs none

Description Dafna Ron 2012-08-08 16:01:06 UTC
Created attachment 603067 [details]
logs

Description of problem:

UI gets the following CanDoAction when extend fails

Error: Cannot extend Storage Domain. Storage device ${lun} is unreachable from ${hostName}.

please fix CanDoAction

Version-Release number of selected component (if applicable):

si13.2

How reproducible:

100%

Steps to Reproduce:
1. in a two host cluster make sure only the hsm host can see the lun and try to extend. 
2. 
3.
  
Actual results:

CanDoAction for failing extend is the following: 

Error: Cannot extend Storage Domain. Storage device ${lun} is unreachable from ${hostName}.

Expected results:

lun and hostname are not getting parameters. 

Additional info: logs

Comment 1 Maor 2012-09-04 14:47:09 UTC
Post upstream at http://gerrit.ovirt.org/#/c/7742/

Comment 2 Maor 2012-09-04 20:26:40 UTC
Merged upstream with Change-Id: I3aa40d4671dc99c2126c131fda36c25d8ed4826e

Comment 6 Dafna Ron 2012-09-16 09:25:15 UTC
checked in si18 and but is not fixed. 

reproduced with following steps due to changes in UI (only SPM can be selected to extend a domain): 

1. using the UI discover and log in to 2 targets from the spm
2. add only one as a domain
3. edit the domain and make sure you can see the second target as logged in
4. disconnect the target from the host using iscsiasm (only the target you want to extend with). 
5. manually log in to the the second target from the hsm using iscsiadm 

result: only the hasm is logged in to the target (Dafna-02 is the target). 

spm: 

[root@localhost ~]# iscsiadm -m session
tcp: [1] 10.35.64.10:3260,1 Dafna-si18-01
tcp: [2] 10.35.64.10:3260,1 Dafna-si18-02
tcp: [3] 10.35.64.10:3260,1 Dafna-si18-03
tcp: [4] 10.35.64.10:3260,1 Dafna-Direct
tcp: [5] 10.35.64.10:3260,1 Dafna-01


hsm: 

[root@gold-vdsd ~]# iscsiadm -m session
tcp: [1] 10.35.64.10:3260,1 Dafna-si18-01
tcp: [2] 10.35.64.10:3260,1 Dafna-si18-02
tcp: [3] 10.35.64.10:3260,1 Dafna-si18-03
tcp: [4] 10.35.64.10:3260,1 Dafna-01
tcp: [5] 10.35.64.10:3260,1 Dafna-02


we are still getting the following error: 

Error: Cannot extend Storage Domain. Storage device is unreachable from ${hostName}.

Comment 7 Laszlo Hornyak 2012-10-11 12:59:11 UTC
Hi,

Dafna, could you give a more detailed instruction for this step:
"manually log in to the the second target from the hsm using iscsiadm"

What is hsm?

Thx!

Comment 8 Yaniv Kaul 2012-10-11 13:01:14 UTC
(In reply to comment #7)
> Hi,
> 
> Dafna, could you give a more detailed instruction for this step:
> "manually log in to the the second target from the hsm using iscsiadm"
> 
> What is hsm?

Host Storage Manager. And I guess it means !SPM (although in real life a SPM is also a HSM, I'm sure in that case Dafna meant not the SPM).

> 
> Thx!

Comment 9 Laszlo Hornyak 2012-10-12 12:28:40 UTC
http://gerrit.ovirt.org/8514

Comment 10 Laszlo Hornyak 2012-10-12 12:31:58 UTC
For this patch I only modified the code to have the same logic as with the "lun", if no host, then empty string should appear. In this way the log message is quite confusing for the user imo. Please comment if you would prefer custom errormessages for these cases! Thx!

Comment 11 Laszlo Hornyak 2012-10-17 16:08:00 UTC
http://gerrit.ovirt.org/8603

Comment 12 Laszlo Hornyak 2012-10-22 14:11:11 UTC
merged upstream c90cbc9d5f1171a1ebec3ef4ce07c1277b977468

Comment 13 Allon Mureinik 2012-10-25 12:59:20 UTC
Merged I30a87e57b0121bfb2a4da9b38c3032604b245bc9

Comment 14 Dafna Ron 2012-11-05 12:55:52 UTC
verified on si24