Bug 847436

Summary:	Review Request: spherical-cow-backgrounds - Spherical Cow desktop backgrounds
Product:	[Fedora] Fedora	Reporter:	Martin Sourada <martin.sourada>
Component:	Package Review	Assignee:	Jaroslav Reznik <jreznik>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jreznik, notting, package-review
Target Milestone:	---	Flags:	jreznik: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-15 15:05:26 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Sourada 2012-08-11 09:08:08 UTC

Spec URL: http://mso.fedorapeople.org/packages/SPECS/spherical-cow-backgrounds.spec
SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/spherical-cow-backgrounds-17.90.2-1.fc17.src.rpm
Description: This package contains desktop backgrounds for the Spherical Cow theme.
Fedora Account System Username: mso

Note: it's practically same as most previous releases, and it's directly based on beefy-miracle-backgrounds package. The package division:
-single: common files for single-screen backgrounds,
-gnome: files intended for gnome DE,
-xfce: files intended for XFCE,
-kde: files intended for KDE,
main package: pulls everything.

The URL isn't functional yet, but I hope to create the wiki page soon.

Comment 1 Martin Sourada 2012-08-12 13:30:30 UTC

Update images appeared, so I updated the rpm as well:
SPEC: http://mso.fedorapeople.org/packages/SPECS/spherical-cow-backgrounds.spec
SRPM: http://mso.fedorapeople.org/packages/SRPMS/spherical-cow-backgrounds-17.91.0-1.fc17.src.rpm

Comment 2 Jaroslav Reznik 2012-08-14 11:10:39 UTC

Name: ok
Release: ok
Summary: ok

Group: not needed anymore, optional tag, http://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
License: ok, CC-BY-SA
URL: not yet created, standard destination for Fedora artwork, please create asap
Sources: ok, md5sum d62c522b46ddf16fe191d8060da449eb

BuildArch: ok

BuildRequires: ok
Requires: ok

Descriptions: ok

Macros used consistently: ok

%clean section is not needed anymore, http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean

rm -rf $RPM_BUILD_ROOT is not needed anymore in %install section, http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

Otherwise it's a simple package, based on beefy-miracle-backgrounds package. You can cleanup the SPEC file according to the current package guidelines but it's not a blocker and the package has to be finalized today.

APPROVED

Comment 3 Martin Sourada 2012-08-14 12:43:26 UTC

Thanks for the review, Jaroslav.

Comment 4 Martin Sourada 2012-08-14 12:44:42 UTC

New Package SCM Request
=======================
Package Name: spherical-cow-backgrounds
Short Description: Spherical Cow desktop backgrounds
Owners: mso
Branches: f18
InitialCC:

Comment 5 Gwyn Ciesla 2012-08-14 13:10:25 UTC

Git done (by process-git-requests).